don't retain reference to temporary

aumuell · aumuell · commit dee9dfe2a3a1 · 2026-05-20T23:50:52.000+02:00
diff --git a/src/module/general/ReadEnsight/ReadEnsight.cpp b/src/module/general/ReadEnsight/ReadEnsight.cpp
@@ -198,10 +198,9 @@ void ReadEnsight::param(const char *paramName, bool inMapLoading)
                         readGeo_ = true;
                         // this is dirty TBD do it better
                         ////// print Number of Timesteps
-                        const TimeSets &ts = case_.getAllTimeSets();
-                        TimeSets::const_iterator tsIter;
+                        const TimeSets ts = case_.getAllTimeSets();
                         int numTs = 0;
-                        for (tsIter = ts.begin(); tsIter != ts.end(); ++tsIter)
+                        for (auto tsIter = ts.begin(); tsIter != ts.end(); ++tsIter)
                         {
                             numTs += (*tsIter)->getNumTs();
                         }

Original file line number	Diff line number	Diff line change
`@@ -198,10 +198,9 @@ void ReadEnsight::param(const char *paramName, bool inMapLoading)`
`198`	`198`	`readGeo_ = true;`
`199`	`199`	`// this is dirty TBD do it better`
`200`	`200`	`////// print Number of Timesteps`
`201`		`- const TimeSets &ts = case_.getAllTimeSets();`
`202`		`- TimeSets::const_iterator tsIter;`
	`201`	`+ const TimeSets ts = case_.getAllTimeSets();`
`203`	`202`	`int numTs = 0;`
`204`		`- for (tsIter = ts.begin(); tsIter != ts.end(); ++tsIter)`
	`203`	`+ for (auto tsIter = ts.begin(); tsIter != ts.end(); ++tsIter)`
`205`	`204`	`{`
`206`	`205`	`numTs += (*tsIter)->getNumTs();`
`207`	`206`	`}`