chore: enabled pmd to fail pipeline

Author: coling01

.github/pmd-ruleset.xml

@@ -18,6 +18,7 @@
         <exclude name="UnitTestAssertionsShouldIncludeMessage"/>
         <exclude name="UnitTestContainsTooManyAsserts"/>
         <exclude name="PreserveStackTrace"/>
+        <exclude name="ImplicitFunctionalInterface"/>
     </rule>
     <rule ref="category/java/codestyle.xml">
         <exclude name="AtLeastOneConstructor"/>

.github/workflows/code-analysis.yml

@@ -23,7 +23,13 @@ jobs:
         with:
           rulesets: '.github/pmd-ruleset.xml'
           sourcePath: 'src/main/java'
+          analyzeModifiedFilesOnly: false
 
       - name: Fail build if there are violations
-        if: steps.pmd.outputs.violations != 0
-        run: exit 1
+        if: always()
+        run: |
+          VIOLATIONS="${{ steps.pmd.outputs.violations }}"
+          if [ -n "$VIOLATIONS" ] && [ "$VIOLATIONS" != "0" ]; then
+            echo "PMD found $VIOLATIONS violations"
+            exit 1
+          fi