Skip to content

Commit 51f6d43

Browse files
committed
chore: fix 2 pmd errors blocking pipeline
1 parent da3d151 commit 51f6d43

File tree

1 file changed

+17
-19
lines changed

1 file changed

+17
-19
lines changed

src/main/java/uk/gov/hmcts/cp/cdk/jobmanager/caseflow/CheckIngestionStatusForDocumentTask.java

Lines changed: 17 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
package uk.gov.hmcts.cp.cdk.jobmanager.caseflow;
22

3-
import static uk.gov.hmcts.cp.cdk.jobmanager.TaskNames.CHECK_INGESTION_STATUS_FOR_DOCUMENT;
4-
import static uk.gov.hmcts.cp.cdk.jobmanager.TaskNames.GENERATE_ANSWER_FOR_QUERY;
5-
import static uk.gov.hmcts.cp.cdk.jobmanager.support.JobManagerKeys.CTX_SINGLE_QUERY_ID;
6-
import static uk.gov.hmcts.cp.cdk.util.TimeUtils.utcNow;
7-
import static uk.gov.hmcts.cp.openapi.model.DocumentIngestionStatus.INGESTION_FAILED;
8-
import static uk.gov.hmcts.cp.openapi.model.DocumentIngestionStatus.INGESTION_SUCCESS;
9-
import static uk.gov.hmcts.cp.openapi.model.DocumentIngestionStatus.INVALID_METADATA;
10-
3+
import jakarta.json.Json;
4+
import jakarta.json.JsonObject;
5+
import lombok.RequiredArgsConstructor;
6+
import lombok.extern.slf4j.Slf4j;
7+
import org.jetbrains.annotations.NotNull;
8+
import org.springframework.http.ResponseEntity;
9+
import org.springframework.stereotype.Component;
1110
import uk.gov.hmcts.cp.cdk.batch.support.QueryResolver;
1211
import uk.gov.hmcts.cp.cdk.domain.DocumentIngestionPhase;
1312
import uk.gov.hmcts.cp.cdk.domain.Query;
@@ -30,21 +29,20 @@
3029
import java.util.stream.Collectors;
3130
import java.util.stream.IntStream;
3231

33-
import jakarta.json.Json;
34-
import jakarta.json.JsonObject;
35-
import lombok.RequiredArgsConstructor;
36-
import org.jetbrains.annotations.NotNull;
37-
import org.slf4j.Logger;
38-
import org.slf4j.LoggerFactory;
39-
import org.springframework.http.ResponseEntity;
40-
import org.springframework.stereotype.Component;
32+
import static uk.gov.hmcts.cp.cdk.jobmanager.TaskNames.CHECK_INGESTION_STATUS_FOR_DOCUMENT;
33+
import static uk.gov.hmcts.cp.cdk.jobmanager.TaskNames.GENERATE_ANSWER_FOR_QUERY;
34+
import static uk.gov.hmcts.cp.cdk.jobmanager.support.JobManagerKeys.CTX_SINGLE_QUERY_ID;
35+
import static uk.gov.hmcts.cp.cdk.util.TimeUtils.utcNow;
36+
import static uk.gov.hmcts.cp.openapi.model.DocumentIngestionStatus.INGESTION_FAILED;
37+
import static uk.gov.hmcts.cp.openapi.model.DocumentIngestionStatus.INGESTION_SUCCESS;
38+
import static uk.gov.hmcts.cp.openapi.model.DocumentIngestionStatus.INVALID_METADATA;
4139

4240
@Component
4341
@RequiredArgsConstructor
4442
@Task(CHECK_INGESTION_STATUS_FOR_DOCUMENT)
43+
@Slf4j
4544
public class CheckIngestionStatusForDocumentTask implements ExecutableTask {
4645

47-
private static final Logger log = LoggerFactory.getLogger(CheckIngestionStatusForDocumentTask.class);
4846
private final DocumentIngestionStatusApi documentIngestionStatusApi;
4947
private final CaseDocumentRepository caseDocumentRepository;
5048
private final QueryResolver queryResolver;
@@ -72,7 +70,7 @@ public ExecutionInfo execute(final ExecutionInfo executionInfo) {
7270
final UUID documentId = parseUuid(jobData.getString("docId", null));
7371
final UUID caseId = parseUuid(jobData.getString("caseId", null));
7472
final String blobName = jobData.getString("blobName", null);
75-
final Set<String> FAILURE_STATUSES = Set.of(
73+
final Set<String> failureStatuses = Set.of(
7674
INGESTION_FAILED.name(),
7775
INVALID_METADATA.name()
7876
);
@@ -143,7 +141,7 @@ public ExecutionInfo execute(final ExecutionInfo executionInfo) {
143141
}
144142

145143
return complete(executionInfo);
146-
} else if (FAILURE_STATUSES.contains(status.toUpperCase())) {
144+
} else if (failureStatuses.contains(status.toUpperCase())) {
147145

148146
updateIngestionPhase(documentId, DocumentIngestionPhase.FAILED);
149147
log.error(

0 commit comments

Comments
 (0)