AMP-168 - addressed review comments.

Author: madhusudan-yasa

src/main/java/uk/gov/hmcts/cp/subscription/clients/model/MaterialResponse.java

@@ -1,13 +1,12 @@
 package uk.gov.hmcts.cp.subscription.clients.model;
 
 import com.fasterxml.jackson.annotation.JsonFormat;
-import com.fasterxml.jackson.annotation.JsonProperty;
 import jakarta.validation.constraints.NotNull;
 import lombok.AllArgsConstructor;
 import lombok.Getter;
 import lombok.NoArgsConstructor;
 
-import java.time.OffsetDateTime;
+import java.time.LocalDateTime;
 import java.util.UUID;
 
 @Getter
@@ -16,20 +15,15 @@
 public class MaterialResponse {
 
     @NotNull
-    @JsonProperty("materialId")
     private UUID materialId;
 
-    @JsonProperty("alfrescoAssetId")
     private UUID alfrescoAssetId;
 
-    @JsonProperty("fileName")
     private String fileName;
 
-    @JsonProperty("mimeType")
     private String mimeType;
 
-    @JsonProperty("materialAddedDate")
     @JsonFormat(shape = JsonFormat.Shape.STRING)
-    private OffsetDateTime materialAddedDate;
+    private LocalDateTime materialAddedDate;
 }
 

src/test/java/uk/gov/hmcts/cp/subscription/clients/MaterialServiceIntegrationTest.java

@@ -22,21 +22,22 @@ class MaterialServiceIntegrationTest {
     @Test
     void should_return_material_by_id() {
 
-        UUID materialId = UUID.fromString("6c198796-08bb-4803-b456-fa0c29ca6021");
+        final UUID materialId = UUID.fromString("6c198796-08bb-4803-b456-fa0c29ca6021");
         MaterialResponse response = materialService.getByMaterialId(materialId);
 
-        assertThat(response).isNotNull();
-        assertThat(response.getMaterialId()).isEqualTo(materialId);
-        assertThat(response.getAlfrescoAssetId()).isEqualTo(UUID.fromString("82257b1b-571d-432e-8871-b0c5b4bd18b1"));
-        assertThat(response.getMimeType()).isEqualTo("application/pdf");
-        assertThat(response.getFileName()).isEqualTo("PrisonCourtRegister_20251219083322.pdf");
-        assertThat(response.getMaterialAddedDate()).isEqualTo("2025-12-19T08:33:29.866Z");
+        assertThat(response).satisfies(resp -> {
+            assertThat(resp.getMaterialId()).isEqualTo(materialId);
+            assertThat(resp.getAlfrescoAssetId()).isEqualTo(UUID.fromString("82257b1b-571d-432e-8871-b0c5b4bd18b1"));
+            assertThat(resp.getMimeType()).isEqualTo("application/pdf");
+            assertThat(resp.getFileName()).isEqualTo("PrisonCourtRegister_20251219083322.pdf");
+        });
     }
 
     @Test
     void should_throw_not_found_when_material_does_not_exist() {
         UUID materialId = UUID.fromString("6c198796-08bb-4803-b456-fa0c29ca6022");
         assertThatThrownBy(() -> materialService.getByMaterialId(materialId))
-                .isInstanceOf(feign.FeignException.NotFound.class);
+                .isInstanceOf(feign.FeignException.NotFound.class)
+                .hasMessageContaining("404");
     }
 }