Merge pull request #38 from hmcts/use=pmd-action

use the pmd action

Author: duncancrawford

.github/workflows/code-analysis.yml

@@ -11,51 +11,19 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
 
-      - name: Install PMD CLI
-        env:
-          PMD_VERSION: '7.14.0'
-        run: |
-          curl -L -o pmd-dist-$PMD_VERSION-bin.zip https://github.com/pmd/pmd/releases/download/pmd_releases%2F$PMD_VERSION/pmd-dist-$PMD_VERSION-bin.zip
-          unzip pmd-dist-$PMD_VERSION-bin.zip
-          mv pmd-bin-$PMD_VERSION /opt/pmd
-          echo "/opt/pmd/bin" >> $GITHUB_PATH
-
-      - name: Run PMD CLI analysis
-        run: |
-          mkdir -p build/reports/pmd
-          
-          set +e
-          /opt/pmd/bin/pmd check \
-            --dir src/main/java \
-            --rulesets \
-            .github/pmd-ruleset.xml \
-            --format html \
-            -r build/reports/pmd/pmd-report.html
-          PMD_EXIT_CODE=$?
-          set -e
-          
-          if [[ "$PMD_EXIT_CODE" -eq 1 ]]; then
-            echo "Unexpected internal error during PMD execution"
-            exit 1
-          elif [[ "$PMD_EXIT_CODE" -eq 2 ]]; then
-            echo "PMD CLI usage error"
-            exit 1
-          fi
-          echo "PMD_EXIT_CODE=$PMD_EXIT_CODE" >> $GITHUB_ENV
+      - uses: actions/setup-java@v4
+        with:
+          distribution: 'temurin'
+          java-version: '21'
 
-      - name: Upload static analysis report on failure
-        if: env.PMD_EXIT_CODE != '0'
-        uses: actions/upload-artifact@v4
+      - uses: pmd/pmd-github-action@v2
         with:
-          name: pmd-report
-          path: build/reports/pmd/pmd-report.html
+          rulesets: '.github/pmd-ruleset.xml'
+          sourcePath: 'src/main/java'
 
-      - name: Check for static code analysis violations
-        run: |
-          if [[ "$PMD_EXIT_CODE" -eq 0 ]]; then
-            echo "No PMD violations"
-          else
-            echo "PMD violations found"
-            exit 1
-          fi
+      - name: Fail build if there are violations
+        if: steps.pmd.outputs.violations != 0
+        run: exit 1