feature: amp-106 further tidy project

* Fixup finals for madhu merge request

Author: coling01

src/apiTest/java/uk/gov/hmcts/cp/http/ActuatorHttpLiveTest.java

@@ -7,7 +7,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-class ActuatorHttpLiveTest {
+class  ActuatorHttpLiveTest {
 
     private final String baseUrl = System.getProperty("app.baseUrl", "http://localhost:8082");
     private final RestTemplate http = new RestTemplate();
@@ -23,7 +23,7 @@ void health_is_up() {
         assertThat(res.getBody()).contains("\"status\":\"UP\"");
     }
 
-    @Disabled
+    @Disabled // Lets revisit this during our monitoring spike
     @Test
     void prometheus_is_exposed() {
         final HttpHeaders httpHeaders = new HttpHeaders();

src/main/java/uk/gov/hmcts/cp/controllers/ExampleController.java

@@ -18,7 +18,7 @@ public class ExampleController implements ExamplesApi {
     private final ExampleService exampleService;
 
     @Override
-    public ResponseEntity<ExampleResponse> getExampleByExampleId(@PathVariable("example_id") @NotNull Long exampleId) {
+    public ResponseEntity<ExampleResponse> getExampleByExampleId(@PathVariable("example_id") @NotNull final Long exampleId) {
 
         log.info("getExampleByExampleId example for {}", exampleId);
         return ResponseEntity.ok(exampleService.getExampleById(exampleId));

src/main/java/uk/gov/hmcts/cp/mappers/ExampleMapper.java

@@ -6,9 +6,10 @@
 import uk.gov.hmcts.cp.entities.ExampleEntity;
 import uk.gov.hmcts.cp.openapi.model.ExampleResponse;
 
+@FunctionalInterface
 @Mapper(componentModel = "spring", unmappedTargetPolicy = ReportingPolicy.IGNORE)
 public interface ExampleMapper {
 
     @Mapping(source = "id", target = "exampleId")
-    public abstract ExampleResponse mapExampleToResponse(ExampleEntity exampleEntity);
+    ExampleResponse mapExampleToResponse(ExampleEntity exampleEntity);
 }

src/main/java/uk/gov/hmcts/cp/services/ExampleService.java

@@ -17,7 +17,7 @@ public class ExampleService {
     private final ExampleMapper exampleMapper;
 
     public ExampleResponse getExampleById(final long exampleId) {
-        ExampleEntity entity = exampleRepository.findById(exampleId).orElseThrow();
+        final ExampleEntity entity = exampleRepository.findById(exampleId).orElseThrow();
         return exampleMapper.mapExampleToResponse(entity);
     }