Documented `\hologoFontSetup` keys not defined

[mbertucci47]

Unless, I am misunderstanding something, it seems like several of the documented keys for \hologoFontSetup are not actually defined. For example, bibsf. The following example errors with Undefined key:

\documentclass{article}
\usepackage{hologo}
\hologoLogoSetup{BibTeX}{variant=sf}
\hologoFontSetup{bibsf=\sffamily}
\begin{document}
\hologo{BibTeX}
\end{document}

(Unrelated, but even without \hologoFontSetup I see no difference between the normal and sf variant.)

The other documented but undefined keys are rm, sc, sy, and logo. This applies to \hologoLogoFontSetup as well.

[davidcarlisle]

Hmm, I just tried in overleaf and it hasn't been defined since 2014 at least

[mbertucci47]

As far as I can see the package does

\def\HOLOGO@temp#1{%
  \kv@define@key{HoLogoFont}{#1}{%
    \ifx\HOLOGO@name\relax
      \HoLogoFont@Def{#1}{##1}%
    \else
      \HoLogoFont@LogoDef\HOLOGO@name{#1}{##1}%
    \fi
  }%
}
\HOLOGO@temp{general}
\HOLOGO@temp{sf}

and then no more key definitions in the HoLogoFont family. For all the others it only does \HoLogoFont@Def{<key name>}.

[davidcarlisle]

yes, so using @temp instead would get the code back in sync with the doc? I can check later....

[mbertucci47]

Yes I think just doing \HOLOGO@temp{bibsf} etc. at the same place as \HOLOGO@temp{general} and \HOLOGO@temp{rm} should be enough.