kvoptions' `\AddToKeyvalOption` compilation error if used with space before `{code}` argument

[jfbu]

Indeed, \KVO@temp is then a macro with a delimited parameter text (by a space).

\NeedsTeXFormat{LaTeX2e}[1995/12/01]
\ProvidesPackage{bugaddtokeyval}[2016/10/29 v1.0 LaTeX package]

% Handle package options via "kvoptions"
\RequirePackage{kvoptions}% tested with kvoptions 2016/05/16 v3.12
\DeclareStringOption[0]{bar0}
\AddToKeyvalOption*{bar0}{\typeout{ok}}% ok
\DeclareStringOption[1]{bar1}
\AddToKeyvalOption*{bar1} {\typeout{ok}}% bug!
% \KVO@temp will be defined with a delimited (by a space) parameter text
% hence bug
\ProcessKeyvalOptions*

\endinput

tex file:

% Time-stamp: <29-10-2016 à 09:56:02 CEST>

% the documentation should say that no space is allowed before {<code>}

\documentclass{article}

% tested with kvoptions 2016/05/16 v3.12
\usepackage{bugaddtokeyval}

\begin{document}

\end{document}

[davidcarlisle]

looks like this can be fixed as follows (shown here as a def in your package but just a change on the three lines marked

\NeedsTeXFormat{LaTeX2e}[1995/12/01]
\ProvidesPackage{bugaddtokeyval}[2016/10/29 v1.0 LaTeX package]

% Handle package options via "kvoptions"
\RequirePackage{kvoptions}% tested with kvoptions 2016/05/16 v3.12

\def\KVO@AddToKeyvalOption#1#2#3{%%%%%%%%%%%%%%%%%%%
  \@ifundefined{KV@#1@#2}{%
    \PackageWarning{kvoptions}{%
      Key `#2' of family `#1' does not exist.\MessageBreak
      Ignoring \string\AddToKeyvalOption
    }%
%%%%%%%%%%%%%%%%%%%%%%%%%%    \@gobble
  }{%
    \edef\KVO@next{%
      \noexpand\KVO@@AddToKeyvalOption
      \expandafter\noexpand\csname KV@#1@#2\endcsname
    }%
    \afterassignment\KVO@next
    \def\KVO@temp##1{#3}%%%%%%%%%%%%%%%%%%%%%%%%
  }%
}

\DeclareStringOption[0]{bar0}
\AddToKeyvalOption*{bar0}{\typeout{ok}}% ok
\DeclareStringOption[1]{bar1}
\AddToKeyvalOption*{bar1} {\typeout{ok}}% bug!
% \KVO@temp will be defined with a delimited (by a space) parameter text
% hence bug
\ProcessKeyvalOptions*

\endinput

Heiko?

[jfbu]

@davidcarlisle incidentally, \@namedef has the same feature. Which gives a convenient way to define space gobbling macro \@namedef{foo} {I gobbled a space token}.

edit: but I prefer \@firstofone{\def\foo} {bar}.

[davidcarlisle]

that's certainly a feature not a bug of namedef as it is a _\def_ like command and takes def not newcommand style argument specifier. \@namedef{foo}#1\@nil#2 \zzz[#1=#2}