|
2 | 2 |
|
3 | 3 | ## Status |
4 | 4 |
|
5 | | -Implemented. Unit tests and the build pass locally. The new managed-device test runs in CI. The |
6 | | -owner's phone check is pending. The owner asked for a PR; that does not authorize merging or |
7 | | -publishing. |
| 5 | +Validated. Local checks and CI pass, including the new managed-device test. On 2026-09-29 the |
| 6 | +owner confirmed on their phone that it works and asked to merge. |
8 | 7 |
|
9 | 8 | ## Context / problem |
10 | 9 |
|
@@ -60,10 +59,10 @@ panel got shorter. Rows growing in place moved nothing. |
60 | 59 | - [x] `revealScrollDelta` returns 0 for a fitting row, the clipped amount at the bottom, the top |
61 | 60 | offset at the top, and top-alignment for a row taller than the panel |
62 | 61 | (`PlaybackArchitectureTest.activeRowRevealMovesOnlyAsFarAsTheClippedPart`). |
63 | | -- [ ] With translations shown only when paused and the spoken line as the last row that fits, |
| 62 | +- [x] With translations shown only when paused and the spoken line as the last row that fits, |
64 | 63 | pausing leaves that line and its translation inside the panel |
65 | 64 | (`SubtitleUiTest.pausingKeepsTheActiveLineAndItsTranslationOnScreen`, managed device in CI). |
66 | | -- [ ] Owner's phone: the report's scenario no longer needs a scroll. |
| 65 | +- [x] Owner's phone: the report's scenario no longer needs a scroll. |
67 | 66 |
|
68 | 67 | ## Validation plan |
69 | 68 |
|
@@ -99,6 +98,6 @@ disappears; a row that was only partly visible keeps the old jump-to-top rule. |
99 | 98 | `./gradlew formatCheck complexityCheck testDebugUnitTest lintDebug assembleDebug assembleDebugAndroidTest`. |
100 | 99 | `PlaybackArchitectureTest` ran 22 tests with 0 failures, including the new one. |
101 | 100 | - Not run locally: `pixel2Api36DebugAndroidTest`, because this host has no KVM. CI's |
102 | | - `managed-device-tests` job runs the new `SubtitleUiTest` case. |
103 | | -- Not run: phone and live YouTube. The owner can check this on the PR's preview APK. |
| 101 | + `managed-device-tests` passed on `cdaaca9`, including the new `SubtitleUiTest` case. |
| 102 | +- Passed on the owner's phone with live YouTube, reported by the owner on 2026-09-29. |
104 | 103 | - Final-head CI status is on the PR. |
0 commit comments