fix(node remote address) Handle correctly the node socket return path

Author: Pierozi

Source/Connection/Connection.php

@@ -114,11 +114,6 @@ abstract class Connection extends Stream implements Stream\IStream\In, Stream\IS
      */
     protected $_remote        = false;
 
-    /**
-     * Remote address.
-     */
-    protected $_remoteAddress = null;
-
     /**
      * Temporize selected connections when selecting.
      */
@@ -284,7 +279,8 @@ public function quietAndMute(): bool
      */
     public function disconnect(): void
     {
-        $this->_disconnect = $this->close();
+        $this->close();
+        $this->_disconnect = true;
     }
 
     /**
@@ -522,7 +518,11 @@ public function isRemoteAddressConsidered(): bool
      */
     public function getRemoteAddress(): string
     {
-        return $this->_remoteAddress;
+        if (null === $this->_node) {
+            return null;
+        }
+
+        return $this->_node->getPeerName();
     }
 
     /**
@@ -556,15 +556,7 @@ public function read(int $length, int $flags = 0)
             return stream_socket_recvfrom($this->getStream(), $length, $flags);
         }
 
-        $out = stream_socket_recvfrom(
-            $this->getStream(),
-            $length,
-            $flags,
-            $address
-        );
-        $this->_remoteAddress = !empty($address) ? $address : null;
-
-        return $out;
+        return stream_socket_recvfrom($this->getStream(), $length, $flags);
     }
 
     /**

Source/Node.php

@@ -121,4 +121,12 @@ public function getEncryptionType(): ?int
     {
         return $this->_encryptionType;
     }
+
+    /**
+     * Get peer connection name.
+     */
+    public function getPeerName(bool $wantPeer = true): string
+    {
+        return stream_socket_get_name($this->getSocket(), $wantPeer);
+    }
 }

Test/Unit/Connection/Connection.php

@@ -693,9 +693,8 @@ public function case_read(): void
 
                 $this->calling($connection)->getStream   = $stream,
                 $this->calling($connection)->isEncrypted = false,
-                $this->function->stream_socket_recvfrom  = function ($_stream, $_length, $_flags, &$address) use ($self, &$called, $stream, $length, $flags) {
+                $this->function->stream_socket_recvfrom  = function ($_stream, $_length, $_flags) use ($self, &$called, $stream, $length, $flags) {
                     $called  = true;
-                    $address = '1.2.3.4';
 
                     $self
                         ->string($_stream)
@@ -714,8 +713,8 @@ public function case_read(): void
                     ->isEqualTo('hello')
                 ->boolean($called)
                     ->isTrue()
-                ->string($connection->getRemoteAddress())
-                    ->isEqualTo('1.2.3.4');
+                ->variable($connection->getRemoteAddress())
+                    ->isNull();
     }
 
     public function case_read_string(): void