Skip to content

Commit 20d8388

Browse files
committed
Merge branch 'issue-126' of https://github.com/hobuinc/silvimetric into issue-126
2 parents 5e4c653 + d1276cc commit 20d8388

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

src/silvimetric/commands/shatter.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -193,23 +193,21 @@ def run(leaves: Leaves, config: ShatterConfig, storage: Storage) -> int:
193193
failures = []
194194

195195
if dc is not None:
196-
# TODO make this a batched operation of like 1000 tasks at a time?
197-
# itertools batched would limit us to >python3.12
198196
futures = [dc.submit(do_one, leaf=leaf, config=config, storage=storage) for leaf in leaves]
199197
res = as_completed(futures, with_results=True, raise_errors=False)
200198
for future, df in res:
201199
if future.status == 'error':
202-
failures.append(pc)
200+
failures.append(df)
203201
continue
204202

205203
if df is not None:
206204
joined_dfs.append(df)
207205

208206
# TODO write out errors to errors storage path?
209207

208+
del df
210209
else:
211210
processes = [delayed(do_one)(leaf, config, storage) for leaf in leaves]
212-
# Handle non-distributed dask scenarios
213211
results = compute(*processes)
214212

215213
joined_dfs = [df for df in results if df is not None]

0 commit comments

Comments
 (0)