File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change 55- Identified and fixed three simplification opportunities in the codebase:
66
77** Dead ` if dry_run ` branch removed (` manager.py ` ):**
8+
89- ` _build_and_post_offer ` had two identical ` return 0 if publish_failures == 0 else 2 ` statements
910 guarded by ` if dry_run: ` / ` else ` . Both branches returned the same expression. Collapsed to one line.
1011
1112** Duplicated subprocess-vs-direct offer-builder logic consolidated:**
13+
1214- ` manager.py ` had ` _build_offer_text_for_request ` + ` _build_offer_text_via_subprocess ` (40 lines).
1315- ` daemon/main.py ` had ` _build_offer_for_action ` (65 lines) reimplementing the same subprocess/direct
1416 branching independently — any change to the subprocess contract required two edits.
2022- Removed ` import shlex ` and ` import subprocess ` from both ` manager.py ` and ` daemon/main.py ` .
2123
2224** ` config/editor.py ` deleted (no production caller):**
25+
2326- ` greenfloor/config/editor.py ` (128 lines) and ` tests/test_config_editor.py ` (96 lines) deleted.
2427- The module supported ` config-history-list ` and ` config-history-revert ` commands removed in the
2528 2026-02-21 simplification pass (CLI 21 → 7 commands). No production code imported it.
You can’t perform that action at this time.
0 commit comments