assert uints that are passed to native bindings

Author: mafintosh

index.js

@@ -20,6 +20,7 @@ const Batch = require('./lib/batch')
 const { manifestHash, defaultSignerManifest, createManifest, isCompat, sign } = require('./lib/verifier')
 const { ReadStream, WriteStream, ByteStream } = require('./lib/streams')
 const {
+  ASSERTION,
   BAD_ARGUMENT,
   SESSION_CLOSED,
   SESSION_NOT_WRITABLE,
@@ -825,6 +826,7 @@ module.exports = class Hypercore extends EventEmitter {
 
   async seek (bytes, opts) {
     if (this.opened === false) await this.opening
+    if (!isValidIndex(bytes)) throw ASSERTION('seek is invalid')
 
     const tree = (opts && opts.tree) || this.core.tree
     const s = tree.seek(bytes, this.padding)
@@ -847,17 +849,17 @@ module.exports = class Hypercore extends EventEmitter {
 
   async has (start, end = start + 1) {
     if (this.opened === false) await this.opening
+    if (!isValidIndex(start) || !isValidIndex(end)) throw ASSERTION('has range is invalid')
 
-    const length = end - start
-    if (length <= 0) return false
-    if (length === 1) return this.core.bitfield.get(start)
+    if (end === start + 1) return this.core.bitfield.get(start)
 
     const i = this.core.bitfield.firstUnset(start)
     return i === -1 || i >= end
   }
 
   async get (index, opts) {
     if (this.opened === false) await this.opening
+    if (!isValidIndex(index)) throw ASSERTION('block index is invalid')
 
     this.tracer.trace('get', { index })
 
@@ -891,6 +893,8 @@ module.exports = class Hypercore extends EventEmitter {
       end = start + 1
     }
 
+    if (!isValidIndex(start) || !isValidIndex(end)) throw ASSERTION('clear range is invalid')
+
     const cleared = (opts && opts.diff) ? { blocks: 0 } : null
 
     if (start >= end) return cleared
@@ -1156,3 +1160,7 @@ function ensureEncryption (core, opts) {
 function createCache (cache) {
   return cache === true ? new Xache({ maxSize: 65536, maxAge: 0 }) : (cache || null)
 }
+
+function isValidIndex (index) {
+  return index === 0 || index > 0
+}

package.json

@@ -50,7 +50,7 @@
     "fast-fifo": "^1.3.0",
     "flat-tree": "^1.9.0",
     "hypercore-crypto": "^3.2.1",
-    "hypercore-errors": "^1.1.1",
+    "hypercore-errors": "^1.2.0",
     "hypercore-id-encoding": "^1.2.0",
     "hypertrace": "^1.2.1",
     "is-options": "^1.0.1",