Don't start downloading when core is not active (#477)

* Don't start downloading when core is not active

* we can simplify

---------

Co-authored-by: Mathias Buus <[email protected]>

Author: HDegroote

lib/replicator.js

@@ -1236,7 +1236,7 @@ module.exports = class Replicator {
     this.peers = []
     this.findingPeers = 0 // updateable from the outside
     this.destroyed = false
-    this.downloading = true
+    this.downloading = false
     this.activeSessions = 0
 
     this._attached = new Set()

test/replicate.js

@@ -1,5 +1,6 @@
 const test = require('brittle')
 const b4a = require('b4a')
+const RAM = require('random-access-memory')
 const NoiseSecretStream = require('@hyperswarm/secret-stream')
 const { create, replicate, unreplicate, eventFlush } = require('./helpers')
 const { makeStreamPair } = require('./helpers/networking.js')
@@ -24,6 +25,27 @@ test('basic replication', async function (t) {
   t.is(d, 5)
 })
 
+test('basic downloading is set immediately after ready', function (t) {
+  t.plan(2)
+
+  const a = new Hypercore(RAM)
+
+  a.on('ready', function () {
+    t.ok(a.replicator.downloading)
+  })
+
+  const b = new Hypercore(RAM, { active: false })
+
+  b.on('ready', function () {
+    t.absent(b.replicator.downloading)
+  })
+
+  t.teardown(async () => {
+    await a.close()
+    await b.close()
+  })
+})
+
 test('basic replication from fork', async function (t) {
   const a = await create()