bug fixes

Author: VigneshVSV

hololinked/client/zmq/consumed_interactions.py

@@ -162,7 +162,7 @@ def read_reply(self, message_id: str, timeout: float | None = None) -> Any:
         """
         if self.owner_inst._noblock_messages.get(message_id) != self:
             raise RuntimeError(f"Message ID {message_id} does not belong to this property.")
-        response = self._sync_zmq_client.recv_response(message_id=message_id.encode())
+        response = self._sync_zmq_client.recv_response(message_id=message_id)
         if not response:
             raise ReplyNotArrivedError(f"could not fetch reply within timeout for message id '{message_id}'")
         self._last_zmq_response = response

hololinked/core/zmq/brokers.py

@@ -1103,7 +1103,7 @@ def send_request(
         )
         return request_message.id
 
-    def recv_response(self, message_id: bytes) -> ResponseMessage:
+    def recv_response(self, message_id: str) -> ResponseMessage:
         """
         Receives response from server. Messages are identified by message id, and out of order messages are sent to
         a cache which may be popped later. This method blocks until the expected message is received or `stop_polling()`

tests/test_99_global_config.py

@@ -99,6 +99,8 @@ def test_05_temp_data_folders():
         assert os.path.exists(folder)
         assert os.path.isdir(folder)
 
+    if os.path.exists(os.path.join(global_config.TEMP_DIR_SECRETS, "apikeys.json")):
+        raise pytest.skip("apikeys.json already exists, skipping test to avoid overwriting existing secrets.")
     assert not os.path.exists(os.path.join(global_config.TEMP_DIR_SECRETS, "apikeys.json"))
     security = APIKeySecurity(name="test-api-key-security")
     security.create(print_value=False)