Skip to content

Commit 1146eb8

Browse files
authored
compat: narwhals 2.23.0 (#6944)
1 parent e8d04b0 commit 1146eb8

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

holoviews/tests/core/test_utils.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,15 @@
4444
unique_array,
4545
wrap_tuple_streams,
4646
)
47+
from holoviews.core.util.dependencies import _no_import_version
4748
from holoviews.core.util.types import masked_types
4849
from holoviews.streams import PointerXY
4950
from holoviews.testing import assert_data_equal
5051

5152
from .._deps import pa_skip, pl, pl_skip
5253

54+
NW_VERSION = _no_import_version("narwhals")
55+
5356
sanitize_identifier = sanitize_identifier_fn.instance()
5457

5558

@@ -1122,7 +1125,9 @@ def test_is_null_or_na_scalar_polars():
11221125
[1.1, 2.2, 3.3],
11231126
"float16",
11241127
"f",
1125-
marks=pytest.mark.xfail(reason="narwhals don't support float16"),
1128+
marks=pytest.mark.xfail(
1129+
condition=NW_VERSION < (2, 23, 0), reason="narwhals don't support float16"
1130+
),
11261131
),
11271132
([1.1, 2.2, 3.3], "float32", "f"),
11281133
([1.1, 2.2, 3.3], "float64", "f"),

0 commit comments

Comments
 (0)