Skip to content

Commit 296baae

Browse files
committed
split into own action
1 parent 03eac9a commit 296baae

2 files changed

Lines changed: 24 additions & 21 deletions

File tree

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
name: optimize-png
2+
on:
3+
pull_request:
4+
branches:
5+
- "*"
6+
# workflow_dispatch:
7+
# inputs:
8+
# run-all:
9+
10+
permissions: {}
11+
12+
concurrency:
13+
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
14+
cancel-in-progress: true
15+
16+
jobs:
17+
optimize_png:
18+
name: optimize-png
19+
runs-on: "ubuntu-latest"
20+
permissions:
21+
contents: write
22+
steps:
23+
- uses: holoviz-dev/holoviz_tasks/optimize-png@optimize-png

.github/workflows/test.yaml

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -46,24 +46,13 @@ jobs:
4646
steps:
4747
- uses: holoviz-dev/holoviz_tasks/pre-commit@ffddda04b2894fea39b407f64d3622d2f19e5a9f # v1
4848

49-
optimize_png:
50-
name: optimize-png
51-
needs: [setup]
52-
runs-on: "ubuntu-latest"
53-
# if: needs.setup.outputs.img_change == 'true'
54-
permissions:
55-
contents: write
56-
steps:
57-
- uses: holoviz-dev/holoviz_tasks/optimize-png@optimize-png
58-
5949
setup:
6050
name: Setup workflow
6151
runs-on: ubuntu-latest
6252
permissions:
6353
pull-requests: read
6454
outputs:
6555
code_change: ${{ steps.filter.outputs.code }}
66-
img_change: ${{ steps.filter.outputs.img }}
6756
matrix: ${{ env.MATRIX }}
6857
matrix_option: ${{ env.MATRIX_OPTION }}
6958
steps:
@@ -82,8 +71,6 @@ jobs:
8271
- 'pixi.toml'
8372
- 'pyproject.toml'
8473
- '.github/workflows/test.yaml'
85-
img:
86-
- '**/*.png'
8774
- name: Set matrix option
8875
env:
8976
GITHUB_EVENT_INPUTS_TARGET: ${{ github.event.inputs.target }}
@@ -245,14 +232,7 @@ jobs:
245232
246233
result_test_suite:
247234
name: result:test
248-
needs:
249-
[
250-
unit_test_suite,
251-
ui_test_suite,
252-
core_test_suite,
253-
type_suite,
254-
optimize_png,
255-
]
235+
needs: [unit_test_suite, ui_test_suite, core_test_suite, type_suite]
256236
if: always()
257237
runs-on: ubuntu-latest
258238
steps:

0 commit comments

Comments
 (0)