test: add pytest.mark.issue marker

Author: hoxbro

holoviews/tests/conftest.py

@@ -26,19 +26,34 @@ def pytest_addoption(parser):
             default=False,
             help=f"Run {marker} related tests",
         )
+    parser.addoption(
+        "--issue",
+        action="store",
+        default=None,
+        type=int,
+        help="Only run tests covering the given GitHub issue number",
+    )
 
 
 def pytest_configure(config):
     for marker in CUSTOM_MARKS:
         config.addinivalue_line("markers", f"{marker}: {marker} test marker")
+    config.addinivalue_line("markers", "issue(id): mark test as covering a specific GitHub issue")
 
 
 def pytest_collection_modifyitems(config, items):
     skipped, selected = [], []
     markers = [m for m in CUSTOM_MARKS if config.getoption(f"--{m}")]
     empty = not markers
+    issue = config.getoption("--issue")
     for item in items:
-        if empty and any(m in item.keywords for m in CUSTOM_MARKS):
+        if issue is not None:
+            marker = item.get_closest_marker("issue")
+            if marker and issue in marker.args:
+                selected.append(item)
+            else:
+                skipped.append(item)
+        elif empty and any(m in item.keywords for m in CUSTOM_MARKS):
             skipped.append(item)
         elif empty:
             selected.append(item)

holoviews/tests/core/data/test_pandasinterface.py

@@ -210,8 +210,8 @@ def test_data_with_tz(self):
         data = hv.Dataset(df).dimension_values("dates")
         np.testing.assert_equal(dates, data)
 
+    @pytest.mark.issue(6305)
     def test_data_groupby_categorial(self):
-        # Test for https://github.com/holoviz/holoviews/issues/6305
         df = pd.DataFrame({"y": [1, 2], "by": ["A", "B"]})
         df["by"] = pd.Categorical(df["by"])
         ds = hv.Dataset(df, kdims="index", vdims="y").to(hv.Scatter, groupby="by")
@@ -391,8 +391,8 @@ def test_select_not_in_index(self):
         expected = self.df.loc[[2]]
         pd.testing.assert_frame_equal(selected.data, expected)
 
+    @pytest.mark.issue(6578)
     def test_select_index_and_column(self):
-        # See https://github.com/holoviz/holoviews/issues/6578
         frame = pd.DataFrame({"number": [1, 1, 2, 2], "color": ["red", "blue", "red", "blue"]})
         index = pd.MultiIndex.from_frame(frame, names=("number", "color"))
         df = pd.DataFrame({"cat": list("abab"), "values": range(4)}, index=index)
@@ -457,9 +457,8 @@ def test_dataset_dataset_ht_dtypes(self):
         assert ds.interface.dtype(ds, "Weight") == np.dtype(int)
         assert ds.interface.dtype(ds, "Height") == np.dtype("float64")
 
+    @pytest.mark.issue(6298)
     def test_regression_no_auto_index(self):
-        # https://github.com/holoviz/holoviews/issues/6298
-
         plot = hv.Scatter(self.df, kdims="number")
         np.testing.assert_equal(
             plot.dimension_values("number"), self.df.index.get_level_values("number")

holoviews/tests/core/data/test_spatialpandas.py

@@ -371,8 +371,8 @@ def test_sort_by_value(self):
         pytest.skip("Not supported")
 
 
+@pytest.mark.issue(6519)
 def test_regression_get_value_array():
-    # See: https://github.com/holoviz/holoviews/pull/6519
     df = pd.DataFrame(
         {"Longitude": [0, 1, 2], "Latitude": [0, 1, 2], "Sensor": ["S1", "S2", "S1"]}
     )

holoviews/tests/core/test_dimensions.py

@@ -100,8 +100,8 @@ def test_name_dimension_repr_params_eval_equality(self):
         dim = hv.Dimension("test", label="Test Dimension", unit="m")
         assert eval(repr(dim), {"Dimension": hv.Dimension}) == dim
 
+    @pytest.mark.issue(5378)
     def test_pprint_value_boolean(self):
-        # https://github.com/holoviz/holoviews/issues/5378
         dim = hv.Dimension("test")
         assert dim.pprint_value(True) == "True"
         assert dim.pprint_value(False) == "False"

holoviews/tests/core/test_layers.py

@@ -26,8 +26,8 @@ def test_overlay_iter(self):
         for el, v in zip(overlay, views, strict=True):
             assert_element_equal(el, v)
 
+    @pytest.mark.issue(5315)
     def test_overlay_iterable(self):
-        # Related to https://github.com/holoviz/holoviews/issues/5315
         c1 = hv.Curve([0, 1])
         c2 = hv.Curve([10, 20])
         hv.Overlay({"a": c1, "b": c2}.values())

holoviews/tests/element/test_selection.py

@@ -26,8 +26,8 @@ def setup_method(self):
     def teardown_method(self):
         hv.Store.current_backend = self._backend
 
+    @pytest.mark.issue(6336)
     def test_index_selection_on_id_column(self):
-        # tests issue in https://github.com/holoviz/holoviews/pull/6336
         x, y = np.random.randn(2, 100)
         idx = np.arange(100)
 

holoviews/tests/operation/test_datashader.py

@@ -1449,8 +1449,8 @@ def test_rasterize_apply_when_instance_with_line_width(self):
         assert isinstance(overlay, hv.Overlay)
         assert len(overlay) == 2
 
+    @pytest.mark.issue(6326)
     def test_rasterize_path_empty_string_as_cat_sep(self):
-        # https://github.com/holoviz/holoviews/issues/6326
         df = pd.DataFrame(
             {
                 "x": [1, 1, np.nan, 3, 3, np.nan],
@@ -1478,8 +1478,8 @@ def test_rasterize_path_empty_string_as_cat_sep(self):
         )
         xr.testing.assert_equal(rasterized.data, expected)
 
+    @pytest.mark.issue(5127)
     def test_rasterize_curve_with_timezone_aware_datetime(self):
-        # Test for https://github.com/holoviz/holoviews/issues/5127
         t = pd.date_range(
             start="2020-01-01 10:00", end="2020-01-01 12:00", freq="h", tz="Asia/Shanghai"
         )
@@ -1679,8 +1679,8 @@ def test_rasterize_overlay_seeds_range_streams():
 
 
 @pytest.mark.usefixtures("bokeh_backend")
+@pytest.mark.issue(6595)
 def test_selector_single_categorical():
-    # Test for https://github.com/holoviz/holoviews/issues/6595
     plot = hv.Points(([0, 1], [0, 1], ["A", "A"]), ["X", "Y"], "C")
     plot = rasterize(plot, aggregator=ds.count_cat("C"), selector=ds.first("X"))
     plot = dynspread(plot)
@@ -2060,8 +2060,8 @@ def test_imagestack_datashader_color_key():
     hv.render(op)  # should not error out
 
 
+@pytest.mark.issue(6154)
 def test_imagestack_datashade_count_cat():
-    # Test for https://github.com/holoviz/holoviews/issues/6154
     df = pd.DataFrame({"x": range(3), "y": range(3), "c": range(3)})
     op = datashade(hv.Points(df), aggregator=ds.count_cat("c"))
     hv.render(op)  # should not error out
@@ -2074,8 +2074,8 @@ def test_imagestack_dynspread():
     hv.render(op)  # should not error out
 
 
+@pytest.mark.issue(6324)
 def test_datashade_count_cat_no_change_inplace():
-    # Test for https://github.com/holoviz/holoviews/issues/6324
     df = pd.DataFrame({"x": range(3), "y": range(3), "c": list(map(str, range(3)))})
     expected_dtype = pd.StringDtype(na_value=np.nan) if PANDAS_GE_3_0_0 else "object"
     assert df["c"].dtype == expected_dtype

holoviews/tests/operation/test_operation.py

@@ -816,8 +816,8 @@ def test_histogram_narwhals_polars_lazy_groupby(self):
 
     @dd_skip
     @pytest.mark.usefixtures("mpl_backend")
+    @pytest.mark.issue(5111)
     def test_histogram_dask_array_mpl(self):
-        # Regression test for https://github.com/holoviz/holoviews/issues/5111
         data = {
             "carrier": ["A", "A", "A", "A", "B", "B", "B", "B", "B"],
             "depdelay": [127.0, 3.0, -3.0, 19.0, 264.0, -6.0, 1.0, 2.0, 83.0],
@@ -1259,16 +1259,10 @@ def test_invert_dendrogram(self, adjoint_dims):
                 assert main1.y_range.factors == main2.y_range.factors[::-1]
                 assert main1.x_range.factors == main2.x_range.factors[::-1]
 
-    @pytest.mark.parametrize(
-        "adjoint_dims",
-        [
-            ["cluster"],
-            ["gene"],
-        ],
-        ids=["right", "top"],
-    )
+    @pytest.mark.parametrize("adjoint_dims", [["cluster"], ["gene"]], ids=["right", "top"])
+    @pytest.mark.issue(6625)
     def test_assure_non_adjoined_axis_is_unchanged_points(self, adjoint_dims):
-        # See: https://github.com/holoviz/holoviews/pull/6625#issuecomment-2981268665
+        # https://github.com/holoviz/holoviews/pull/6625#issuecomment-2981268665
         plot = hv.Points(self.df2, kdims=["gene", "cluster"])
         main1 = self.bokeh_renderer.get_plot(plot).handles["plot"]
 
@@ -1281,8 +1275,8 @@ def test_assure_non_adjoined_axis_is_unchanged_points(self, adjoint_dims):
             case ["gene"]:
                 assert main1.y_range.factors == main2.y_range.factors
 
+    @pytest.mark.issue(6669)
     def test_assure_non_adjoined_axis_is_unchanged_heatmap(self):
-        # Follow up to previous test, see
         # https://github.com/holoviz/holoviews/pull/6669#issuecomment-3237153317
         plot = hv.HeatMap(self.ds)
         main1 = self.bokeh_renderer.get_plot(plot).handles["plot"]

holoviews/tests/plotting/bokeh/test_annotationplot.py

@@ -596,9 +596,8 @@ def test_dynamicmap_overlay_hspans(self):
         assert plot_el.handles["y_range"].start == plot_dmap.handles["y_range"].start
         assert plot_el.handles["y_range"].end == plot_dmap.handles["y_range"].end
 
+    @pytest.mark.issue(6289)
     def test_hspans_no_upper_range(self):
-        # Test for: https://github.com/holoviz/holoviews/issues/6289
-
         dim = hv.Dimension("p", label="prob", range=(0, None))
         fig = hv.Curve([(0, 0.6), (1, 0.3), (2, 0.4), (3, 0.45)], kdims="x", vdims=dim)
         spans = hv.HSpans([(0, 0.2), (0.4, 0.6)], kdims=["x", dim])

holoviews/tests/plotting/bokeh/test_barplot.py

@@ -97,8 +97,8 @@ def test_box_whisker_multi_level_sorted_alphanumerically(self):
             ("10", "B"),
         ]
 
+    @pytest.mark.issue(5850)
     def test_bars_multi_level_two_factors_in_overlay(self):
-        # See: https://github.com/holoviz/holoviews/pull/5850
         box = hv.Bars(
             (["1", "2", "3"] * 10, ["A", "B"] * 15, np.random.randn(30)),
             ["Group", "Category"],
@@ -486,15 +486,15 @@ def test_bars_continuous_datetime_duplicates(self):
         plot = bokeh_renderer.get_plot(bars)
         np.testing.assert_almost_equal(plot.handles["glyph"].width, 69120000.0)
 
+    @pytest.mark.issue(6364)
     def test_bars_continuous_datetime_timezone_in_overlay(self):
-        # See: https://github.com/holoviz/holoviews/issues/6364
         bars = hv.Bars((pd.date_range("1/1/2000", periods=10, tz="UTC"), np.random.rand(10)))
         overlay = hv.Overlay([bars])
         plot = bokeh_renderer.get_plot(overlay)
         assert isinstance(plot.handles["xaxis"], DatetimeAxis)
 
+    @pytest.mark.issue(6288)
     def test_bars_continuous_datetime_stacked(self):
-        # See: https://github.com/holoviz/holoviews/issues/6288
         data = pd.DataFrame(
             {
                 "x": pd.to_datetime(
@@ -612,8 +612,8 @@ def test_bar_narrow_non_monotonous_xvals(self):
 
 
 @pytest.mark.parametrize("stacked", [True, False])
+@pytest.mark.issue(6580)
 def test_grouped_bars_color(stacked):
-    # Test for https://github.com/holoviz/holoviews/issues/6580
     data = {
         "A": ["A1", "A1", "A1", "A1", "A2", "A2", "A2", "A2", "A3", "A3", "A3", "A3"],
         "B": ["B1", "B2", "B3", "B4", "B1", "B2", "B3", "B4", "B1", "B2", "B3", "B4"],