reverse when logic

Author: hoxbro

holoviews/core/data/narwhals.py

@@ -192,17 +192,12 @@ def range(cls, dataset, dimension):
                 return np.nan, np.nan
             return cmin.item(), cmax.item()
         else:
+            col = nw.col(name)
             if dimension.nodata is not None:
-                expr = (
-                    nw.when(nw.col(name) == dimension.nodata)
-                    .then(None)
-                    .otherwise(nw.col(name))
-                    .alias(name)
+                df_column = df_column.select(
+                    nw.when(col != dimension.nodata).then(col)
                 )
-                df_column = df_column.select(expr)
-            if dataset.data.implementation in _NO_DROP_NULL:
-                col = nw.col(name)
-            else:
+            if dataset.data.implementation not in _NO_DROP_NULL:
                 col = nw.col(name).drop_nulls()
             # NOTE: Some narwhals backends (duckdb) will return nan as
             # the max value

holoviews/tests/core/data/test_narwhalsinterface.py

@@ -7,7 +7,6 @@
 
 from holoviews import Dataset, Dimension
 from holoviews.core.data import NarwhalsInterface
-from holoviews.core.util.dependencies import PANDAS_GE_3_0_0
 
 from .base import HeterogeneousColumnTests, InterfaceTests
 
@@ -221,9 +220,6 @@ def frame(self, *args, **kwargs):
 
         return dd.from_pandas(pd.DataFrame(*args, **kwargs), npartitions=2)
 
-    @pytest.mark.xfail(PANDAS_GE_3_0_0, reason="pandas 3.0")
-    def test_dataset_nodata_range(self):
-        return super().test_dataset_nodata_range()
 
 class IbisNarwhalsLazyInterfaceTests(BaseNarwhalsLazyInterfaceTests):
     __test__ = True