Ban re.match

Author: hoxbro

holoviews/plotting/bokeh/styles.py

@@ -141,7 +141,7 @@ def mpl_to_bokeh(properties):
 validators = {
     "angle": angle.is_valid,
     "alpha": alpha.is_valid,
-    "color": lambda x: color.is_valid(x) or (isinstance(x, str) and RGB_HEX_REGEX.match(x)),
+    "color": lambda x: color.is_valid(x) or (isinstance(x, str) and RGB_HEX_REGEX.search(x)),
     "font_size": font_size.is_valid,
     "line_dash": dash_pattern.is_valid,
     "marker": lambda x: marker.is_valid(x) or x in markers,

holoviews/plotting/mpl/util.py

@@ -51,7 +51,7 @@ def is_color(color):
     """Checks if supplied object is a valid color spec."""
     if not isinstance(color, str):
         return False
-    elif RGB_HEX_REGEX.match(color):
+    elif RGB_HEX_REGEX.search(color):
         return True
     elif color in COLOR_ALIASES:
         return True

holoviews/plotting/plotly/util.py

@@ -124,7 +124,7 @@
 
 # Regular expression to extract any trailing digits from a subplot-style
 # string.
-_subplot_re = re.compile(r"\D*(\d+)")
+_subplot_re = re.compile(r"(\d+)")
 
 
 def _get_subplot_number(subplot_val):
@@ -149,7 +149,7 @@ def _get_subplot_number(subplot_val):
     -------
     int
     """
-    match = _subplot_re.match(subplot_val)
+    match = _subplot_re.search(subplot_val)
     if match:
         subplot_number = int(match.group(1))
     else:

holoviews/plotting/util.py

@@ -1164,7 +1164,7 @@ def scale_fontsize(size, scaling):
     """Scales a numeric or string font size."""
     ext = None
     if isinstance(size, str):
-        match = re.match(r"[-+]?\d*\.\d+|\d+", size)
+        match = re.search(r"^[-+]?\d*\.\d+|\d+", size)
         if match:
             value = match.group()
             ext = size.replace(value, "")

pyproject.toml

@@ -182,6 +182,7 @@ select = [
     "PT",
     "RUF",
     "TC",
+    "TID251",
     "UP",
     "W",
 ]
@@ -247,6 +248,9 @@ allow-dict-calls-with-keyword-arguments = true
 [tool.ruff.lint.pydocstyle]
 convention = "numpy"
 
+[tool.ruff.lint.flake8-tidy-imports.banned-api]
+"re.match".msg = "Use re.search with '^' instead of re.match"
+
 [tool.ty.src]
 include = [
     "holoviews/*.py",