-
-
Notifications
You must be signed in to change notification settings - Fork 575
Set Tabulator to render into explicit popup container #7299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7299 +/- ##
==========================================
- Coverage 87.40% 87.37% -0.04%
==========================================
Files 347 347
Lines 53618 53618
==========================================
- Hits 46867 46850 -17
- Misses 6751 6768 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Yep, seeing that too. Not sure what to do about it. |
|
What about making this setting an option for now? Or maybe document the behavior, as it can be enabled by the configuration directly: |
ba47027 to
d56e6ff
Compare
|
So I'm leaning towards merging this as is now. It turns out the weird offset issue occurs only for the last column and in the meantime this PR also fixes: and the coloring of the popup. |
|
Okay, fixed the offset issue by inserting an empty last column. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |

Not entirely happy with this as the editor isn't aligned quite right but I played with all the options and couldn't find one that produced the correct result.
Fixes #7295