Skip to content

Commit 966a2ab

Browse files
Remove type annotation test per reviewer feedback
Co-authored-by: MarcSkovMadsen <42288570+MarcSkovMadsen@users.noreply.github.com>
1 parent 68ed636 commit 966a2ab

1 file changed

Lines changed: 0 additions & 29 deletions

File tree

tests/testreactive.py

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -775,32 +775,3 @@ def test_reactive_set_value_attributeerror():
775775
x = rx(1)
776776
with pytest.raises(AttributeError, match="'rx' has no attribute 'value'"):
777777
x.value = 1
778-
779-
780-
def test_parameter_rx_type_annotation():
781-
"""Test that Parameter.rx property has type annotation."""
782-
import inspect
783-
from param.reactive import reactive_ops
784-
785-
class P(param.Parameterized):
786-
a = param.Number()
787-
788-
p = P(a=1)
789-
790-
# Verify that rx property returns reactive_ops instance (runtime check)
791-
assert isinstance(p.param.a.rx, reactive_ops)
792-
793-
# Verify that calling rx() returns rx instance
794-
rx_expr = p.param.a.rx()
795-
assert isinstance(rx_expr, rx)
796-
797-
# Verify that the property has the correct return type annotation
798-
rx_property = type(p.param.a).rx
799-
assert hasattr(rx_property, 'fget'), "rx should be a property"
800-
sig = inspect.signature(rx_property.fget)
801-
# Check that there is a return annotation
802-
assert sig.return_annotation != inspect.Signature.empty, \
803-
"rx property should have a return type annotation"
804-
# The annotation should be 'reactive_ops' as a string (forward reference)
805-
assert sig.return_annotation == 'reactive_ops', \
806-
f"Expected return annotation 'reactive_ops', got {sig.return_annotation}"

0 commit comments

Comments
 (0)