Commit dad6d84
committed
Harden DataFrameLike for production
* Raise a clear ImportError naming the install command when the
optional narwhals package is missing, instead of a bare
ModuleNotFoundError (declaration-time fail-fast, matching how
DataFrame fails on missing pandas).
* Document the serialization asymmetry (backend-neutral records out,
pandas in) and that cuDF/Modin are Narwhals-supported but not run
in CI (cuDF is GPU-only, Modin's pinned deps conflict with the
test environment).
* Annotate the inherited in-place ordered defaulting as deliberate
DataFrame parity.
* Add a skip-guarded Modin test and add narwhals + polars to the
type-check environment so pyright validates the Narwhals API
rather than skipping an unresolved import.1 parent 7a8a300 commit dad6d84
3 files changed
Lines changed: 50 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3506 | 3506 | | |
3507 | 3507 | | |
3508 | 3508 | | |
3509 | | - | |
3510 | | - | |
| 3509 | + | |
| 3510 | + | |
| 3511 | + | |
3511 | 3512 | | |
3512 | | - | |
| 3513 | + | |
| 3514 | + | |
| 3515 | + | |
| 3516 | + | |
| 3517 | + | |
| 3518 | + | |
| 3519 | + | |
3513 | 3520 | | |
3514 | 3521 | | |
3515 | 3522 | | |
| |||
3518 | 3525 | | |
3519 | 3526 | | |
3520 | 3527 | | |
3521 | | - | |
3522 | | - | |
| 3528 | + | |
| 3529 | + | |
| 3530 | + | |
| 3531 | + | |
| 3532 | + | |
3523 | 3533 | | |
3524 | 3534 | | |
3525 | 3535 | | |
3526 | 3536 | | |
3527 | 3537 | | |
3528 | | - | |
| 3538 | + | |
| 3539 | + | |
3529 | 3540 | | |
3530 | 3541 | | |
3531 | 3542 | | |
| |||
3544 | 3555 | | |
3545 | 3556 | | |
3546 | 3557 | | |
| 3558 | + | |
| 3559 | + | |
| 3560 | + | |
| 3561 | + | |
| 3562 | + | |
| 3563 | + | |
| 3564 | + | |
3547 | 3565 | | |
3548 | 3566 | | |
3549 | 3567 | | |
| |||
3671 | 3689 | | |
3672 | 3690 | | |
3673 | 3691 | | |
| 3692 | + | |
| 3693 | + | |
| 3694 | + | |
| 3695 | + | |
3674 | 3696 | | |
3675 | 3697 | | |
3676 | 3698 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
209 | 209 | | |
210 | 210 | | |
211 | 211 | | |
| 212 | + | |
212 | 213 | | |
213 | 214 | | |
| 215 | + | |
214 | 216 | | |
215 | 217 | | |
216 | 218 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
33 | 40 | | |
34 | 41 | | |
35 | 42 | | |
| 43 | + | |
36 | 44 | | |
37 | 45 | | |
38 | 46 | | |
| |||
77 | 85 | | |
78 | 86 | | |
79 | 87 | | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
80 | 100 | | |
81 | 101 | | |
82 | 102 | | |
| |||
0 commit comments