pr #16

Author: holtwick

src/serialize-markdown.ts

@@ -53,11 +53,11 @@ function serialize(node: VNode | VElement, context: SerializeContext = {
   count: 0,
 }): string {
   if (node.nodeType === VNode.DOCUMENT_FRAGMENT_NODE) {
-    return (node.children || []).map(c => serialize(c, { ...context })).join('')
+    return (node.childNodes || []).map(c => serialize(c, { ...context })).join('')
   }
   else if (isVElement(node)) {
     const tag: string = node.tagName.toLowerCase()
-    const handleChildren = (ctx?: Partial<SerializeContext>): string => (node.children || []).map(c => serialize(c, { ...context, ...ctx })).join('')
+    const handleChildren = (ctx?: Partial<SerializeContext>): string => (node.childNodes || []).map(c => serialize(c, { ...context, ...ctx })).join('')
     const fn = rules[tag]
     if (fn)
       return fn(node as VElement, handleChildren, context)

src/serialize-plaintext.ts

@@ -13,13 +13,13 @@ function serialize(node: VNode | VElement, context: SerializeContext = {
   count: 0,
 }): string {
   if (node.nodeType === VNode.DOCUMENT_FRAGMENT_NODE) {
-    return node.children.map(c => serialize(c, { ...context })).join('')
+    return node.childNodes.map(c => serialize(c, { ...context })).join('')
   }
 
   else if (isVElement(node)) {
     const tag: string = node.tagName.toLowerCase()
 
-    const handleChildren = (ctx?: Partial<SerializeContext>): string => node.children.map(c => serialize(c, { ...context, ...ctx })).join('')
+    const handleChildren = (ctx?: Partial<SerializeContext>): string => node.childNodes.map(c => serialize(c, { ...context, ...ctx })).join('')
 
     const rules: Record<string, () => string> = {
       br: () => `${handleChildren()}\n`,

src/serialize-safehtml.ts

@@ -31,11 +31,11 @@ function serialize(node: VNode, context: SerializeContext = {
   count: 0,
 }): string {
   if (node.nodeType === VNode.DOCUMENT_FRAGMENT_NODE) {
-    return (node.children || []).map(c => serialize(c, { ...context })).join('')
+    return (node.childNodes || []).map(c => serialize(c, { ...context })).join('')
   }
   else if (isVElement(node)) {
     const tag: string = node.tagName?.toLowerCase()
-    const handleChildren = (ctx?: Partial<SerializeContext>): string => (node.children || []).map(c => serialize(c, { ...context, ...ctx })).join('')
+    const handleChildren = (ctx?: Partial<SerializeContext>): string => (node.childNodes || []).map(c => serialize(c, { ...context, ...ctx })).join('')
     const fn = baseRules[tag]
     if (fn)
       return fn(node, handleChildren)

src/utils.spec.ts

@@ -12,7 +12,7 @@ describe('utils', () => {
 
     const body = removeBodyContainer(doc)
     expect(body.render()).toMatchInlineSnapshot(
-      `"<title>Hello Title</title>Hello world"`,
+      `"<title>Hello Title</title>"`,
     )
   })
 })

src/vcss.spec.tsx

@@ -357,7 +357,7 @@ describe('css', () => {
         <iframe src="https://www.youtube.com/watch?v=cqHqLQgVCgY" />
       </div>
     )
-    // Should not throw, should return true for iframe
+    // Should not throw, should return true for Fiframe
     expect(matchSelector('div[data-youtube-video] iframe', element.querySelector('iframe'))).toBe(true)
     // Should return true for div
     expect(matchSelector('div[data-youtube-video]', element)).toBe(true)

src/vdom.spec.tsx

@@ -724,4 +724,11 @@ describe('vdom', () => {
   //   div.remove()
   //   div.replaceWith('x')
   // })
+
+
+  it('should include only elements in children', () => {
+    const el: VElement = parseHTML('<div> <p>Hello</p> </div>').firstChild
+    expect(el.childNodes).toHaveLength(3)
+    expect(el.children).toHaveLength(1)
+  })
 })

src/vdom.ts

@@ -187,7 +187,7 @@ export class VNode {
   }
 
   get children() {
-    return this._childNodes || []
+    return (this._childNodes || []).filter<any>(isVElement)
   }
 
   get firstChild() {