Merge pull request #1764 from TKuh/source_range_functor

mohamed-barakat · web-flow · commit bda519cec442 · 2025-07-03T07:17:34.000+02:00
diff --git a/AdditiveClosuresForCAP/PackageInfo.g b/AdditiveClosuresForCAP/PackageInfo.g
@@ -10,7 +10,7 @@ SetPackageInfo( rec(
 
 PackageName := "AdditiveClosuresForCAP",
 Subtitle := "Additive closures for pre-abelian categories",
-Version := "2025.07-02",
+Version := "2025.07-03",
 Date := (function ( ) if IsBound( GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE ) then return GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE; else return Concatenation( ~.Version{[ 1 .. 4 ]}, "-", ~.Version{[ 6, 7 ]}, "-01" ); fi; end)( ),
 License := "GPL-2.0-or-later",
 
diff --git a/AdditiveClosuresForCAP/gap/AdditiveClosure.gi b/AdditiveClosuresForCAP/gap/AdditiveClosure.gi
@@ -352,9 +352,9 @@ InstallMethod( ExtendFunctorToAdditiveClosures,
   function( F )
     local source_cat, range_cat, additive_closure_source, additive_closure_range, name, G;
     
-    source_cat := AsCapCategory( Source( F ) );
+    source_cat := SourceOfFunctor( F );
     
-    range_cat := AsCapCategory( Range( F ) );
+    range_cat := RangeOfFunctor( F );
     
     additive_closure_source := AdditiveClosure( source_cat );
     
@@ -396,9 +396,9 @@ InstallMethod( ExtendFunctorWithAdditiveRangeToFunctorFromAdditiveClosureOfSourc
   function( F )
     local source_cat, range_cat, additive_closure_source, name, G;
     
-    source_cat := AsCapCategory( Source( F ) );
+    source_cat := SourceOfFunctor( F );
     
-    range_cat := AsCapCategory( Range( F ) );
+    range_cat := RangeOfFunctor( F );
     
     if not ( HasIsAdditiveCategory( range_cat ) and IsAdditiveCategory( range_cat ) ) then
       
@@ -455,7 +455,7 @@ InstallMethod( ExtendFunctorToAdditiveClosureOfSource,
   function( F )
     local range_cat;
     
-    range_cat := AsCapCategory( Range( F ) );
+    range_cat := RangeOfFunctor( F );
     
     if not ( HasIsAdditiveCategory( range_cat ) and IsAdditiveCategory( range_cat ) ) then
       
@@ -477,7 +477,7 @@ InstallMethod( ExtendNaturalTransformationToAdditiveClosureOfSource,
     
     G := Range( eta );
     
-    range := AsCapCategory( Range( F ) ); # = Range( G )
+    range := RangeOfFunctor( F ); # = Range( G )
     
     if not ( HasIsAdditiveCategory( range ) and IsAdditiveCategory( range ) ) then
         
diff --git a/CAP/gap/CategoriesCategory.gi b/CAP/gap/CategoriesCategory.gi
@@ -170,13 +170,15 @@ InstallMethod( SourceOfFunctor,
           [ IsCapFunctor ],
   
   F -> AsCapCategory( Source( F ) )
+  
 );
 
 ##
 InstallMethod( RangeOfFunctor,
           [ IsCapFunctor ],
   
   F -> AsCapCategory( Range( F ) )
+  
 );
 
 BindGlobal( "CAP_INTERNAL_FUNCTOR_CREATE_FILTER_LIST",
@@ -229,7 +231,7 @@ InstallMethod( FunctorMorphismOperation,
     
     filter_list := CAP_INTERNAL_FUNCTOR_CREATE_FILTER_LIST( functor, "morphism" );
     
-    range_cat := AsCapCategory( Range( functor ) );
+    range_cat := RangeOfFunctor( functor );
     
     filter_list := Concatenation( [ ObjectFilter( range_cat ) ], filter_list, [ ObjectFilter( range_cat ) ] );
     
@@ -269,7 +271,7 @@ InstallMethod( AddMorphismFunction,
     
     filter_list := CAP_INTERNAL_FUNCTOR_CREATE_FILTER_LIST( functor, "morphism" );
     
-    range_cat := AsCapCategory( Range( functor ) );
+    range_cat := RangeOfFunctor( functor );
     
     filter_list := Concatenation( [ ObjectFilter( range_cat ) ], filter_list, [ ObjectFilter( range_cat ) ] );
     
@@ -316,8 +318,8 @@ InstallGlobalFunction( ApplyFunctor,
     
     arguments := List( arguments ); # in Julia, `arguments` is a tuple which we cannot assign to below
     
-    source_category := AsCapCategory( Source( functor ) );
-    range_category := AsCapCategory( Range( functor ) );
+    source_category := SourceOfFunctor( functor );
+    range_category := RangeOfFunctor( functor );
     input_signature := InputSignature( functor );
 
     # n-ary functor and unary argument (possibly in product category)
@@ -433,8 +435,8 @@ AddPreCompose( category,
     local new_functor;
     
     new_functor := CapFunctor( Concatenation( "Precomposition of ", Name( left_functor ), " and ", Name( right_functor ) ),
-                               AsCapCategory( Source( left_functor ) ),
-                               AsCapCategory( Range( right_functor ) ) );
+                               SourceOfFunctor( left_functor ),
+                               RangeOfFunctor( right_functor ) );
     
     AddObjectFunction( new_functor,
       
@@ -553,7 +555,7 @@ AddUniversalMorphismIntoDirectProductWithGivenDirectProduct( category,
     
     name_string := Concatenation( 
       "Product functor from ", 
-      Name( AsCapCategory( Source( sink[1] ) ) ), 
+      Name( SourceOfFunctor( sink[1] ) ),
       " to ", 
       Name( AsCapCategory( direct_product ) ) 
     );
@@ -701,8 +703,8 @@ InstallMethod( InstallFunctor,
     object_filters := CAP_INTERNAL_FUNCTOR_CREATE_FILTER_LIST( functor, "object" );
     morphism_filters := CAP_INTERNAL_FUNCTOR_CREATE_FILTER_LIST( functor, "morphism" );
     
-    object_product_filters := [ ObjectFilter( AsCapCategory( Source( functor ) ) ) ];
-    morphism_product_filters := [ MorphismFilter( AsCapCategory( Source( functor ) ) ) ];
+    object_product_filters := [ ObjectFilter( SourceOfFunctor( functor ) ) ];
+    morphism_product_filters := [ MorphismFilter( SourceOfFunctor( functor ) ) ];
     
     install_list := [
         [ install_name, object_filters ],
@@ -944,7 +946,7 @@ InstallMethod( NaturalTransformationOperation,
     
     filter_list := CAP_INTERNAL_FUNCTOR_CREATE_FILTER_LIST( Source( trafo ), "object" );
     
-    filter_list := Concatenation( [ ObjectFilter( AsCapCategory( Range( Source( trafo ) ) ) ) ], filter_list, [ ObjectFilter( AsCapCategory( Range( Source( trafo ) ) ) ) ] );
+    filter_list := Concatenation( [ ObjectFilter( RangeOfFunctor( Source( trafo ) ) ) ], filter_list, [ ObjectFilter( RangeOfFunctor( Source( trafo ) ) ) ] );
     
     return NewOperation( Concatenation( "CAP_NATURAL_TRANSFORMATION_", Name( trafo ), "_OPERATION" ), filter_list );
     
@@ -959,7 +961,7 @@ InstallMethod( AddNaturalTransformationFunction,
     
     filter_list := CAP_INTERNAL_FUNCTOR_CREATE_FILTER_LIST( Source( trafo ), "object" );
     
-    filter_list := Concatenation( [ ObjectFilter( AsCapCategory( Range( Source( trafo ) ) ) ) ], filter_list, [ ObjectFilter( AsCapCategory( Range( Source( trafo ) ) ) ) ] );
+    filter_list := Concatenation( [ ObjectFilter( RangeOfFunctor( Source( trafo ) ) ) ], filter_list, [ ObjectFilter( RangeOfFunctor( Source( trafo ) ) ) ] );
     
     if not IsBound( trafo!.function_list ) then
         
@@ -984,7 +986,7 @@ InstallGlobalFunction( ApplyNaturalTransformation,
     
     source_functor := Source( trafo );
     
-    range_category := AsCapCategory( Range( source_functor ) );
+    range_category := RangeOfFunctor( source_functor );
     
     arguments := arg{[ 2 .. Length( arg ) ]};
     
@@ -1044,7 +1046,7 @@ InstallMethod( InstallNaturalTransformation,
     
     object_filters := CAP_INTERNAL_FUNCTOR_CREATE_FILTER_LIST( Source( trafo ), "object" );
     
-    object_product_filters := [ ObjectFilter( AsCapCategory( Source( Source( trafo ) ) ) ) ];
+    object_product_filters := [ ObjectFilter( SourceOfFunctor( Source( trafo ) ) ) ];
     
     for current_filters in [
         [ install_name, object_filters ],
diff --git a/FreydCategoriesForCAP/PackageInfo.g b/FreydCategoriesForCAP/PackageInfo.g
@@ -10,7 +10,7 @@ SetPackageInfo( rec(
 
 PackageName := "FreydCategoriesForCAP",
 Subtitle := "Freyd categories - Formal (co)kernels for additive categories",
-Version := "2025.06-09",
+Version := "2025.07-01",
 Date := (function ( ) if IsBound( GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE ) then return GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE; else return Concatenation( ~.Version{[ 1 .. 4 ]}, "-", ~.Version{[ 6, 7 ]}, "-01" ); fi; end)( ),
 License := "GPL-2.0-or-later",
 
diff --git a/FreydCategoriesForCAP/gap/AdelmanCategory.gi b/FreydCategoriesForCAP/gap/AdelmanCategory.gi
@@ -1014,7 +1014,7 @@ InstallMethod( AdelmanCategoryFunctorInducedByUniversalProperty,
   function( functor ) 
     local source, range, induced_functor;
     
-    range := AsCapCategory( Range( functor ) );
+    range := RangeOfFunctor( functor );
     
     if not ( HasIsAbelianCategory( range ) and IsAbelianCategory( range ) ) then
         
@@ -1028,7 +1028,7 @@ InstallMethod( AdelmanCategoryFunctorInducedByUniversalProperty,
         
     fi;
     
-    source := AdelmanCategory( AsCapCategory( Source( functor ) ) );
+    source := AdelmanCategory( SourceOfFunctor( functor ) );
     
     induced_functor :=
         CapFunctor( 
diff --git a/FreydCategoriesForCAP/gap/LinearClosure.gi b/FreydCategoriesForCAP/gap/LinearClosure.gi
@@ -879,9 +879,9 @@ InstallMethodWithCache( ExtendFunctorToLinearClosureOfSource,
   function( F, linear_closure_source, ring_map )
     local source_cat, range_cat, name, G;
     
-    source_cat := AsCapCategory( Source( F ) );
+    source_cat := SourceOfFunctor( F );
     
-    range_cat := AsCapCategory( Range( F ) );
+    range_cat := RangeOfFunctor( F );
     
     if not IsIdenticalObj( source_cat, UnderlyingCategory( linear_closure_source ) ) then
       
diff --git a/GeneralizedMorphismsForCAP/PackageInfo.g b/GeneralizedMorphismsForCAP/PackageInfo.g
@@ -10,7 +10,7 @@ SetPackageInfo( rec(
 
 PackageName := "GeneralizedMorphismsForCAP",
 Subtitle := "Implementations of generalized morphisms for the CAP project",
-Version := "2025.06-01",
+Version := "2025.07-01",
 Date := (function ( ) if IsBound( GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE ) then return GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE; else return Concatenation( ~.Version{[ 1 .. 4 ]}, "-", ~.Version{[ 6, 7 ]}, "-01" ); fi; end)( ),
 License := "GPL-2.0-or-later",
 
diff --git a/GeneralizedMorphismsForCAP/gap/GeneralizedMorphismCategoryByCospans.gd b/GeneralizedMorphismsForCAP/gap/GeneralizedMorphismCategoryByCospans.gd
@@ -229,8 +229,8 @@ DeclareAttribute( "GeneralizedMorphismByCospansObject",
 
 #! @Description
 #!  Lift the <E>exact</E> functor <A>F</A> to a functor <M>A \to B</M>,
-#!  where <M>A := </M> <C>GeneralizedMorphismCategoryByCospans( AsCapCategory( Source( </C><A>F</A><C> ) ) )</C>
-#!  and <M>B := </M> <C>GeneralizedMorphismCategoryByCospans( AsCapCategory( Range( </C><A>F</A><C> ) ) )</C>.
+#!  where <M>A := </M> <C>GeneralizedMorphismCategoryByCospans( SourceOfFunctor( </C><A>F</A><C> ) )</C>
+#!  and <M>B := </M> <C>GeneralizedMorphismCategoryByCospans( RangeOfFunctor( </C><A>F</A><C> ) )</C>.
 #! @Arguments F, name
 DeclareOperation( "AsGeneralizedMorphismByCospan",
         [ IsCapFunctor, IsString ] );
diff --git a/GeneralizedMorphismsForCAP/gap/GeneralizedMorphismCategoryByCospans.gi b/GeneralizedMorphismsForCAP/gap/GeneralizedMorphismCategoryByCospans.gi
@@ -371,8 +371,8 @@ InstallMethod( AsGeneralizedMorphismByCospan,
   function( F, name )
     local A, B, gmcF;
     
-    A := GeneralizedMorphismCategoryByCospans( AsCapCategory( Source( F ) ) : FinalizeCategory := true );
-    B := GeneralizedMorphismCategoryByCospans( AsCapCategory( Range( F ) ) : FinalizeCategory := true );
+    A := GeneralizedMorphismCategoryByCospans( SourceOfFunctor( F ) : FinalizeCategory := true );
+    B := GeneralizedMorphismCategoryByCospans( RangeOfFunctor( F ) : FinalizeCategory := true );
     
     gmcF := CapFunctor( name, A, B );
     
diff --git a/GradedModulePresentationsForCAP/PackageInfo.g b/GradedModulePresentationsForCAP/PackageInfo.g
@@ -10,7 +10,7 @@ SetPackageInfo( rec(
 
 PackageName := "GradedModulePresentationsForCAP",
 Subtitle := "Presentations for graded modules",
-Version := "2025.02-01",
+Version := "2025.07-01",
 Date := (function ( ) if IsBound( GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE ) then return GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE; else return Concatenation( ~.Version{[ 1 .. 4 ]}, "-", ~.Version{[ 6, 7 ]}, "-01" ); fi; end)( ),
 License := "GPL-2.0-or-later",
 
diff --git a/GradedModulePresentationsForCAP/gap/LiftPresentationTransformation.gi b/GradedModulePresentationsForCAP/gap/LiftPresentationTransformation.gi
@@ -28,7 +28,7 @@ BindGlobal( "CAP_INTERNAL_LiftNaturalTransformationToGradedModuleFunctor",
     
     range_functor := Range( natural_transformation );
     
-    underlying_category := AsCapCategory( Source( source_functor ) );
+    underlying_category := SourceOfFunctor( source_functor );
     
     ring := underlying_category!.ring_for_representation_category;
     
@@ -90,7 +90,7 @@ BindGlobal( "CAP_INTERNAL_LiftNaturalTransformationToGradedModuleNatTrans",
     
     range_func := CAP_INTERNAL_LiftNaturalTransformationToGradedModuleFunctor( nat_trans, left );
     
-    underlying_category := AsCapCategory( Source( range_func ) );
+    underlying_category := SourceOfFunctor( range_func );
     
     ring := underlying_category!.ring_for_representation_category;
     
diff --git a/LinearAlgebraForCAP/PackageInfo.g b/LinearAlgebraForCAP/PackageInfo.g
@@ -10,7 +10,7 @@ SetPackageInfo( rec(
 
 PackageName := "LinearAlgebraForCAP",
 Subtitle := "Category of Matrices over a Field for CAP",
-Version := "2025.06-03",
+Version := "2025.07-01",
 Date := (function ( ) if IsBound( GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE ) then return GAPInfo.SystemEnvironment.GAP_PKG_RELEASE_DATE; else return Concatenation( ~.Version{[ 1 .. 4 ]}, "-", ~.Version{[ 6, 7 ]}, "-01" ); fi; end)( ),
 License := "GPL-2.0-or-later",
 
diff --git a/LinearAlgebraForCAP/examples/Functors.g b/LinearAlgebraForCAP/examples/Functors.g
@@ -20,7 +20,7 @@ V3 := DirectSum( V1, V1, V1 );;
 pi1 := ProjectionInFactorOfDirectSum( [ V1, V1 ], 1 );;
 pi2 := ProjectionInFactorOfDirectSum( [ V3, V1 ], 1 );;
 value1 := ApplyFunctor( F, pi1, pi2 );;
-input := ProductCategoryMorphism( AsCapCategory( Source( F ) ), [ pi1, Opposite( pi2 ) ] );;
+input := ProductCategoryMorphism( SourceOfFunctor( F ), [ pi1, Opposite( pi2 ) ] );;
 value2 := ApplyFunctor( F, input );;
 IsCongruentForMorphisms( value1, value2 );
 #! true
@@ -29,14 +29,14 @@ InstallFunctor( F, "F_installation" );;
 F_installation( pi1, pi2 );;
 F_installation( input );;
 F_installationOnObjects( V1, V1 );;
-F_installationOnObjects( ProductCategoryObject( AsCapCategory( Source( F ) ), [ V1, Opposite( V1 ) ] ) );;
+F_installationOnObjects( ProductCategoryObject( SourceOfFunctor( F ), [ V1, Opposite( V1 ) ] ) );;
 F_installationOnMorphisms( pi1, pi2 );;
 F_installationOnMorphisms( input );;
 
 F2 := CapFunctor( "CohomForVec2", ProductCategory( [ vec, Opposite( vec ) ] ), vec );;
 AddObjectFunction( F2, a -> obj_func( a[1], Opposite( a[2] ) ) );;
 AddMorphismFunction( F2, function( source, datum, range ) return mor_func( source, datum[1], Opposite( datum[2] ), range ); end );;
-input := ProductCategoryMorphism( AsCapCategory( Source( F2 ) ), [ pi1, Opposite( pi2 ) ] );;
+input := ProductCategoryMorphism( SourceOfFunctor( F2 ), [ pi1, Opposite( pi2 ) ] );;
 value3 := ApplyFunctor( F2, input );;
 IsCongruentForMorphisms( value1, value3 );
 #! true
@@ -45,6 +45,6 @@ Display( InputSignature( F2 ) );
 
 InstallFunctor( F2, "F_installation2" );;
 F_installation2( input );;
-F_installation2OnObjects( ProductCategoryObject( AsCapCategory( Source( F2 ) ), [ V1, Opposite( V1 ) ] ) );;
+F_installation2OnObjects( ProductCategoryObject( SourceOfFunctor( F2 ), [ V1, Opposite( V1 ) ] ) );;
 F_installation2OnMorphisms( input );;
 #! @EndExample
