Skip to content

Move Weak* method records #1754

Description

@TKuh

When splitting parts of FreydCategoriesForCAP into a new package AdditiveClosureForCAP, the CategoryOfRows should also be moved.
It installs some Weak* operations, e.g.,

## Operations important for Freyd categories
AddWeakKernelEmbedding( category,
function( cat, morphism )
local homalg_matrix;
homalg_matrix := ReducedSyzygiesOfRows( UnderlyingMatrix( morphism ) );
return CategoryOfRowsMorphism( cat, CategoryOfRowsObject( cat, NrRows( homalg_matrix ) ), homalg_matrix, Source( morphism ) ); # taking NrRows could be avoided by using a WithGiven version
end );

These Weak* operations are, however, declared and generated in gap/FreydCategoriesForCAP.gi

WeakKernelEmbedding := rec(
filter_list := [ "category", "morphism" ],
input_arguments_names := [ "cat", "alpha" ],
output_range_getter_string := "Source( alpha )",
output_range_getter_preconditions := [ ],
with_given_object_position := "Source",
return_type := "morphism",
dual_operation := "WeakCokernelProjection",
is_merely_set_theoretic := true ),

So the new AdditiveClosureForCAP package would need to load FreydCategoriesForCAP to work properly and vice versa. This defeats the purpose of splitting.

A workaround would be to move these method records into a separate file (which should be done anyways) and move it to CAP itself.
I could also only extract the method records relevant to CategoryOfRows and move them to AdditiveClosureForCAP, but that is ugly.

Any better solutions?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions