Skip to content

Commit 8367930

Browse files
authored
Jewish Calendar quality scale (#143763)
1 parent d71b124 commit 8367930

File tree

2 files changed

+100
-1
lines changed

2 files changed

+100
-1
lines changed
Lines changed: 100 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,100 @@
1+
rules:
2+
# Bronze
3+
action-setup: done
4+
appropriate-polling: done
5+
brands: done
6+
common-modules: done
7+
config-flow-test-coverage: done
8+
config-flow: done
9+
dependency-transparency: done
10+
docs-actions: done
11+
docs-high-level-description: done
12+
docs-installation-instructions: done
13+
docs-removal-instructions: done
14+
entity-event-setup: done
15+
entity-unique-id: done
16+
has-entity-name: done
17+
runtime-data: done
18+
test-before-configure:
19+
status: exempt
20+
comment: Local calculation does not require configuration.
21+
test-before-setup:
22+
status: exempt
23+
comment: Local calculation does not require setup.
24+
unique-config-entry:
25+
status: done
26+
comment: >-
27+
The multiple config entry was removed due to multiple bugs in the
28+
integration and low ROI.
29+
We might consider revisiting this as an additional feature in the future
30+
to allow supportong multiple languages for states, multiple locations and maybe
31+
use it as a solution for multiple Zmanim configurations.
32+
33+
# Silver
34+
action-exceptions: done
35+
config-entry-unloading: done
36+
docs-configuration-parameters: done
37+
docs-installation-parameters: done
38+
entity-unavailable:
39+
status: exempt
40+
comment: This integration cannot be unavailable since it's a local calculation.
41+
integration-owner: done
42+
log-when-unavailable:
43+
status: exempt
44+
comment: This integration cannot be unavailable since it's a local calculation.
45+
parallel-updates: done
46+
reauthentication-flow:
47+
status: exempt
48+
comment: This integration does not require reauthentication, since it is a local calculation.
49+
test-coverage:
50+
status: todo
51+
comment: |-
52+
The following points should be addressed:
53+
54+
* Don't use if-statements in tests (test_jewish_calendar_sensor, test_shabbat_times_sensor)
55+
56+
# Gold
57+
devices: done
58+
diagnostics: done
59+
discovery-update-info:
60+
status: exempt
61+
comment: This is a local calculation and does not require discovery.
62+
discovery:
63+
status: exempt
64+
comment: This is a local calculation and does not require discovery.
65+
docs-data-update: todo
66+
docs-examples: todo
67+
docs-known-limitations:
68+
status: exempt
69+
comment: No known limitations.
70+
docs-supported-devices:
71+
status: exempt
72+
comment: This integration does not support physical devices.
73+
docs-supported-functions: done
74+
docs-troubleshooting:
75+
status: exempt
76+
comment: There are no more detailed troubleshooting instructions available.
77+
docs-use-cases: todo
78+
dynamic-devices:
79+
status: exempt
80+
comment: This integration does not have physical devices.
81+
entity-category: done
82+
entity-device-class: done
83+
entity-disabled-by-default: done
84+
entity-translations: done
85+
exception-translations: done
86+
icon-translations: done
87+
reconfiguration-flow: done
88+
repair-issues:
89+
status: exempt
90+
comment: There are no issues that can be repaired.
91+
stale-devices:
92+
status: exempt
93+
comment: This integration does not have physical devices.
94+
95+
# Platinum
96+
async-dependency: todo
97+
inject-websession:
98+
status: exempt
99+
comment: This integration does not require a web session.
100+
strict-typing: done

script/hassfest/quality_scale.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -529,7 +529,6 @@ class Rule:
529529
"itunes",
530530
"izone",
531531
"jellyfin",
532-
"jewish_calendar",
533532
"joaoapps_join",
534533
"juicenet",
535534
"justnimbus",

0 commit comments

Comments
 (0)