Deprecate fireplace mode switch instead of removing it

- Keep fireplace mode switch but disable it by default
- Add deprecation warning when switch is used
- Direct users to use climate preset mode instead
- Provides smoother migration path for existing users

Author: magnusoverli

homeassistant/components/flexit_bacnet/icons.json

@@ -61,6 +61,12 @@
         "state": {
           "off": "mdi:radiator-off"
         }
+      },
+      "fireplace_mode": {
+        "default": "mdi:fireplace",
+        "state": {
+          "off": "mdi:fireplace-off"
+        }
       }
     }
   }

homeassistant/components/flexit_bacnet/strings.json

@@ -128,6 +128,9 @@
       },
       "electric_heater": {
         "name": "Electric heater"
+      },
+      "fireplace_mode": {
+        "name": "Fireplace mode"
       }
     }
   },
@@ -150,5 +153,11 @@
     "switch_turn": {
       "message": "Failed to turn the switch {state}."
     }
+  },
+  "issues": {
+    "deprecated_fireplace_switch": {
+      "description": "The fireplace mode switch entity `{entity_id}` is deprecated and will be removed in a future version.\n\nFireplace mode has been moved to a climate preset to better match the device interface. Please update your automations to use the climate entity preset instead.\n\n**To migrate:**\n\n1. Open your automation that uses `{entity_id}`\n2. Replace the switch service call with:\n```yaml\nservice: climate.set_preset_mode\ntarget:\n  entity_id: {climate_entity_id}\ndata:\n  preset_mode: fireplace\n```\n\n3. After migrating your automations, you can safely disable this switch entity.",
+      "title": "Fireplace mode switch is deprecated"
+    }
   }
 }

homeassistant/components/flexit_bacnet/switch.py

@@ -16,6 +16,8 @@
 from homeassistant.core import HomeAssistant
 from homeassistant.exceptions import HomeAssistantError
 from homeassistant.helpers.entity_platform import AddConfigEntryEntitiesCallback
+from homeassistant.helpers.issue_registry import IssueSeverity, async_create_issue
+from homeassistant.util import slugify
 
 from .const import DOMAIN
 from .coordinator import FlexitConfigEntry, FlexitCoordinator
@@ -46,6 +48,14 @@ class FlexitSwitchEntityDescription(SwitchEntityDescription):
         turn_on_fn=lambda data: data.activate_cooker_hood(),
         turn_off_fn=lambda data: data.deactivate_cooker_hood(),
     ),
+    FlexitSwitchEntityDescription(
+        key="fireplace_mode",
+        translation_key="fireplace_mode",
+        entity_registry_enabled_default=False,
+        is_on_fn=lambda data: data.fireplace_ventilation_status,
+        turn_on_fn=lambda data: data.trigger_fireplace_mode(),
+        turn_off_fn=lambda data: data.trigger_fireplace_mode(),
+    ),
 )
 
 
@@ -92,6 +102,26 @@ def is_on(self) -> bool:
 
     async def async_turn_on(self, **kwargs: Any) -> None:
         """Turn switch on."""
+        # Create deprecation warning for fireplace mode switch
+        if self.entity_description.key == "fireplace_mode":
+            # Derive climate entity ID from switch entity ID
+            climate_entity_id = self.entity_id.replace("switch.", "climate.").replace(
+                "_fireplace_mode", ""
+            )
+            async_create_issue(
+                self.hass,
+                DOMAIN,
+                f"deprecated_switch_{slugify(self.entity_id)}",
+                is_fixable=False,
+                issue_domain=DOMAIN,
+                severity=IssueSeverity.WARNING,
+                translation_key="deprecated_fireplace_switch",
+                translation_placeholders={
+                    "entity_id": self.entity_id,
+                    "climate_entity_id": climate_entity_id,
+                },
+            )
+
         try:
             await self.entity_description.turn_on_fn(self.coordinator.data)
         except (asyncio.exceptions.TimeoutError, ConnectionError, DecodingError) as exc:
@@ -107,6 +137,26 @@ async def async_turn_on(self, **kwargs: Any) -> None:
 
     async def async_turn_off(self, **kwargs: Any) -> None:
         """Turn switch off."""
+        # Create deprecation warning for fireplace mode switch
+        if self.entity_description.key == "fireplace_mode":
+            # Derive climate entity ID from switch entity ID
+            climate_entity_id = self.entity_id.replace("switch.", "climate.").replace(
+                "_fireplace_mode", ""
+            )
+            async_create_issue(
+                self.hass,
+                DOMAIN,
+                f"deprecated_switch_{slugify(self.entity_id)}",
+                is_fixable=False,
+                issue_domain=DOMAIN,
+                severity=IssueSeverity.WARNING,
+                translation_key="deprecated_fireplace_switch",
+                translation_placeholders={
+                    "entity_id": self.entity_id,
+                    "climate_entity_id": climate_entity_id,
+                },
+            )
+
         try:
             await self.entity_description.turn_off_fn(self.coordinator.data)
         except (asyncio.exceptions.TimeoutError, ConnectionError, DecodingError) as exc:

tests/components/flexit_bacnet/snapshots/test_switch.ambr

@@ -97,6 +97,55 @@
     'state': 'on',
   })
 # ---
+# name: test_switches[switch.device_name_fireplace_mode-entry]
+  EntityRegistryEntrySnapshot({
+    'aliases': set({
+    }),
+    'area_id': None,
+    'capabilities': None,
+    'config_entry_id': <ANY>,
+    'config_subentry_id': <ANY>,
+    'device_class': None,
+    'device_id': <ANY>,
+    'disabled_by': None,
+    'domain': 'switch',
+    'entity_category': None,
+    'entity_id': 'switch.device_name_fireplace_mode',
+    'has_entity_name': True,
+    'hidden_by': None,
+    'icon': None,
+    'id': <ANY>,
+    'labels': set({
+    }),
+    'name': None,
+    'options': dict({
+    }),
+    'original_device_class': <SwitchDeviceClass.SWITCH: 'switch'>,
+    'original_icon': None,
+    'original_name': 'Fireplace mode',
+    'platform': 'flexit_bacnet',
+    'previous_unique_id': None,
+    'suggested_object_id': None,
+    'supported_features': 0,
+    'translation_key': 'fireplace_mode',
+    'unique_id': '0000-0001-fireplace_mode',
+    'unit_of_measurement': None,
+  })
+# ---
+# name: test_switches[switch.device_name_fireplace_mode-state]
+  StateSnapshot({
+    'attributes': ReadOnlyDict({
+      'device_class': 'switch',
+      'friendly_name': 'Device Name Fireplace mode',
+    }),
+    'context': <ANY>,
+    'entity_id': 'switch.device_name_fireplace_mode',
+    'last_changed': <ANY>,
+    'last_reported': <ANY>,
+    'last_updated': <ANY>,
+    'state': 'on',
+  })
+# ---
 # name: test_switches_implementation[switch.device_name_electric_heater-state]
   StateSnapshot({
     'attributes': ReadOnlyDict({

tests/components/flexit_bacnet/test_switch.py

@@ -23,6 +23,7 @@
 ENTITY_ID = "switch.device_name_electric_heater"
 
 
+@pytest.mark.usefixtures("entity_registry_enabled_by_default")
 async def test_switches(
     hass: HomeAssistant,
     snapshot: SnapshotAssertion,