Enhance tests for Motion Gateway interface detection

Refactor tests for Motion Gateway interface detection, adding tests for dual and single NIC scenarios, interface timeout handling, and fallback mechanisms.

Author: kvanbiesen

tests/components/motion_blinds/test_gateway.py

@@ -1,21 +1,143 @@
-"""Test the Motionblinds config flow."""
+"""Tests for Motion Gateway interface detection."""
+import asyncio
+from unittest.mock import AsyncMock, MagicMock, patch
 
-from unittest.mock import Mock
+import pytest
 
-from motionblinds import DEVICE_TYPES_WIFI, BlindType
+from homeassistant.components.motion_blindds.gateway import ConnectMotionGateway
+from homeassistant.components.motion_blinds.const import DEFAULT_INTERFACE
 
-from homeassistant.components.motion_blinds.gateway import device_name
-from homeassistant.core import HomeAssistant
 
-TEST_BLIND_MAC = "abcdefghujkl0001"
+MOCK_ADAPTERS_DUAL_NIC = [
+    {
+        "ipv4": [{"address": "192.168.1.10"}],
+        "enabled": True,
+        "default": True,
+    },
+    {
+        "ipv4": [{"address": "192.168.20.10"}],
+        "enabled": True,
+        "default": False,
+    },
+]
 
+MOCK_ADAPTERS_SINGLE_NIC = [
+    {
+        "ipv4": [{"address": "192.168.1.10"}],
+        "enabled": True,
+        "default": True,
+    },
+]
 
-async def test_device_name(hass: HomeAssistant) -> None:
-    """test_device_name."""
-    blind = Mock()
-    blind.blind_type = BlindType.RollerBlind.name
-    blind.mac = TEST_BLIND_MAC
-    assert device_name(blind) == "RollerBlind 0001"
 
-    blind.device_type = DEVICE_TYPES_WIFI[0]
-    assert device_name(blind) == "RollerBlind"
+async def test_get_interfaces_dual_nic_default_prioritized(hass):
+    """Test that default interface is first in list with multiple NICs."""
+    gateway = ConnectMotionGateway(hass)
+
+    with patch(
+        "homeassistant.components.motion_blinds.gateway.network.async_get_adapters",
+        return_value=MOCK_ADAPTERS_DUAL_NIC,
+    ):
+        interfaces = await gateway.async_get_interfaces()
+
+    # Default interface (192.168.1.10) must be first
+    assert interfaces[0] == "192.168.1.10"
+
+
+async def test_get_interfaces_single_nic(hass):
+    """Test that single NIC setup still works correctly."""
+    gateway = ConnectMotionGateway(hass)
+
+    with patch(
+        "homeassistant.components.motion_blinds.gateway.network.async_get_adapters",
+        return_value=MOCK_ADAPTERS_SINGLE_NIC,
+    ):
+        interfaces = await gateway.async_get_interfaces()
+
+    assert interfaces[0] == "192.168.1.10"
+
+
+async def test_check_interface_timeout_moves_to_next(hass):
+    """Test that a timed out interface check moves to the next interface."""
+    gateway = ConnectMotionGateway(hass)
+    successful_interface = "192.168.1.10"
+
+    with patch(
+        "homeassistant.components.motion_blinds.gateway.network.async_get_adapters",
+        return_value=MOCK_ADAPTERS_DUAL_NIC,
+    ), patch(
+        "homeassistant.components.motion_blinds.gateway.AsyncMotionMulticast"
+    ) as mock_multicast, patch(
+        "homeassistant.components.motion_blinds.gateway.MotionGateway"
+    ):
+        mock_instance = MagicMock()
+        mock_instance.Start_listen = AsyncMock()
+        mock_instance.Stop_listen = MagicMock()
+        mock_multicast.return_value = mock_instance
+
+        call_count = 0
+
+        async def check_interface_side_effect():
+            nonlocal call_count
+            call_count += 1
+            # First interface times out, second succeeds
+            if call_count == 1:
+                await asyncio.sleep(10)  # Will be cancelled by timeout
+            return True
+
+        with patch.object(
+            gateway,
+            "check_interface",
+            side_effect=check_interface_side_effect,
+        ):
+            result = await gateway.async_check_interface("192.168.1.1", "testkey")
+
+    assert result == successful_interface
+
+
+async def test_check_interface_found_on_first_try(hass):
+    """Test that correct interface on first try returns immediately."""
+    gateway = ConnectMotionGateway(hass)
+
+    with patch(
+        "homeassistant.components.motion_blinds.gateway.network.async_get_adapters",
+        return_value=MOCK_ADAPTERS_DUAL_NIC,
+    ), patch(
+        "homeassistant.components.motion_blinds.gateway.AsyncMotionMulticast"
+    ) as mock_multicast, patch(
+        "homeassistant.components.motion_blinds.gateway.MotionGateway"
+    ):
+        mock_instance = MagicMock()
+        mock_instance.Start_listen = AsyncMock()
+        mock_instance.Stop_listen = MagicMock()
+        mock_multicast.return_value = mock_instance
+
+        with patch.object(gateway, "check_interface", return_value=True):
+            result = await gateway.async_check_interface("192.168.1.1", "testkey")
+
+    # Should return the first (default) interface immediately
+    assert result == "192.168.1.10"
+
+
+async def test_check_interface_none_working_falls_back(hass):
+    """Test fallback to stored interface when none work."""
+    gateway = ConnectMotionGateway(hass, interface="0.0.0.0")
+
+    with patch(
+        "homeassistant.components.motion_blinds.gateway.network.async_get_adapters",
+        return_value=MOCK_ADAPTERS_DUAL_NIC,
+    ), patch(
+        "homeassistant.components.motion_blinds.gateway.AsyncMotionMulticast"
+    ) as mock_multicast, patch(
+        "homeassistant.components.motion_blinds.gateway.MotionGateway"
+    ):
+        mock_instance = MagicMock()
+        mock_instance.Start_listen = AsyncMock()
+        mock_instance.Stop_listen = MagicMock()
+        mock_multicast.return_value = mock_instance
+
+        with patch.object(gateway, "check_interface", return_value=False):
+            result = await gateway.async_check_interface("192.168.1.1", "testkey")
+
+    # Should fall back to stored interface
+    assert result == "0.0.0.0"