Skip to content

Commit e4afd71

Browse files
committed
Add constants
1 parent 6308a2e commit e4afd71

4 files changed

Lines changed: 15 additions & 7 deletions

File tree

homeassistant/components/compensation/__init__.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,15 @@
3030
from homeassistant.helpers.typing import ConfigType
3131

3232
from .const import (
33+
CONF_COMPENSATED_VALUE,
3334
CONF_COMPENSATION,
3435
CONF_DATAPOINTS,
3536
CONF_DEGREE,
3637
CONF_LOWER_LIMIT,
3738
CONF_POLYNOMIAL,
3839
CONF_POLYNOMIAL_CONFIG,
3940
CONF_PRECISION,
41+
CONF_UNCOMPENSATED_VALUE,
4042
CONF_UPPER_LIMIT,
4143
DATA_COMPENSATION,
4244
DEFAULT_DEGREE,
@@ -173,7 +175,7 @@ async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:
173175
CONF_DATAPOINTS
174176
]
175177
new_data_points = [
176-
[data_point["uncompensated_value"], data_point["compensated_value"]]
178+
[data_point[CONF_UNCOMPENSATED_VALUE], data_point[CONF_COMPENSATED_VALUE]]
177179
for data_point in data_points
178180
]
179181
config[CONF_DEGREE] = config[CONF_POLYNOMIAL_CONFIG][CONF_DEGREE]

homeassistant/components/compensation/config_flow.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,13 @@
3535
)
3636

3737
from .const import (
38+
CONF_COMPENSATED_VALUE,
3839
CONF_DATAPOINTS,
3940
CONF_DEGREE,
4041
CONF_LOWER_LIMIT,
4142
CONF_POLYNOMIAL_CONFIG,
4243
CONF_PRECISION,
44+
CONF_UNCOMPENSATED_VALUE,
4345
CONF_UPPER_LIMIT,
4446
DEFAULT_DEGREE,
4547
DEFAULT_NAME,
@@ -64,15 +66,15 @@ async def get_options_schema(handler: SchemaCommonFlowHandler) -> vol.Schema:
6466
multiple=True,
6567
translation_key=CONF_DATAPOINTS,
6668
fields={
67-
"uncompensated_value": ObjectSelectorField(
69+
CONF_UNCOMPENSATED_VALUE: ObjectSelectorField(
6870
required=True,
6971
selector=NumberSelector(
7072
NumberSelectorConfig(
7173
mode=NumberSelectorMode.BOX
7274
)
7375
),
7476
),
75-
"compensated_value": ObjectSelectorField(
77+
CONF_COMPENSATED_VALUE: ObjectSelectorField(
7678
required=True,
7779
selector=NumberSelector(
7880
NumberSelectorConfig(

homeassistant/components/compensation/const.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818
CONF_PRECISION = "precision"
1919
CONF_POLYNOMIAL = "polynomial"
2020
CONF_POLYNOMIAL_CONFIG = "polynomial_config"
21+
CONF_COMPENSATED_VALUE = "compensated_value"
22+
CONF_UNCOMPENSATED_VALUE = "uncompensated_value"
2123

2224

2325
DATA_COMPENSATION: HassKey[dict[str, Any]] = HassKey("compensation_data")

tests/components/compensation/test_config_flow.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,13 @@
33
from unittest.mock import AsyncMock
44

55
from homeassistant.components.compensation.const import (
6+
CONF_COMPENSATED_VALUE,
67
CONF_DATAPOINTS,
78
CONF_DEGREE,
89
CONF_LOWER_LIMIT,
910
CONF_POLYNOMIAL_CONFIG,
1011
CONF_PRECISION,
12+
CONF_UNCOMPENSATED_VALUE,
1113
CONF_UPPER_LIMIT,
1214
DEFAULT_NAME,
1315
DOMAIN,
@@ -43,8 +45,8 @@ async def test_user_flow(
4345
CONF_LOWER_LIMIT: False,
4446
CONF_POLYNOMIAL_CONFIG: {
4547
CONF_DATAPOINTS: [
46-
{"compensated_value": 6, "uncompensated_value": 5},
47-
{"compensated_value": 8, "uncompensated_value": 7},
48+
{CONF_COMPENSATED_VALUE: 6, CONF_UNCOMPENSATED_VALUE: 5},
49+
{CONF_COMPENSATED_VALUE: 8, CONF_UNCOMPENSATED_VALUE: 7},
4850
],
4951
CONF_DEGREE: 1,
5052
},
@@ -62,8 +64,8 @@ async def test_user_flow(
6264
CONF_NAME: "Compensation",
6365
CONF_POLYNOMIAL_CONFIG: {
6466
CONF_DATAPOINTS: [
65-
{"compensated_value": 6, "uncompensated_value": 5},
66-
{"compensated_value": 8, "uncompensated_value": 7},
67+
{CONF_COMPENSATED_VALUE: 6, CONF_UNCOMPENSATED_VALUE: 5},
68+
{CONF_COMPENSATED_VALUE: 8, CONF_UNCOMPENSATED_VALUE: 7},
6769
],
6870
CONF_DEGREE: 1,
6971
},

0 commit comments

Comments
 (0)