Add shared rainbird device lock and increase calendar timeout#172002
Open
allenporter wants to merge 1 commit into
Open
Add shared rainbird device lock and increase calendar timeout#172002allenporter wants to merge 1 commit into
allenporter wants to merge 1 commit into
Conversation
Contributor
|
Hey there @konikvranik, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Rain Bird integration to better handle controller modules that can only process one request at a time by serializing coordinator I/O and extending the schedule fetch timeout.
Changes:
- Create a shared
asyncio.Lock()during config entry setup and pass it to both update coordinators. - Wrap both coordinators’
_async_update_datacalls with the shared lock to prevent concurrent polling. - Increase the schedule/calendar fetch timeout to 30 seconds.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
homeassistant/components/rainbird/coordinator.py |
Adds a shared lock to both coordinators’ update paths and increases the schedule fetch timeout constant. |
homeassistant/components/rainbird/__init__.py |
Instantiates the shared lock during entry setup and wires it into the coordinators. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Rain Bird LNK Wi-Fi modules are extremely resource-constrained and can only reliably handle a single HTTP request at a time. The background coordinators (
RainbirdUpdateCoordinatorandRainbirdScheduleUpdateCoordinator) run on independent update intervals and can execute overlapping requests concurrently, causing the device to return busy warnings (NAKs) or go unavailable.This PR:
asyncio.Lock()(device_lock) inside the config entry's setup to prevent concurrent coordinator requests.async with self._device_lock.CALENDAR_TIMEOUT_SECONDS = 30) to accommodate slower responses from certain controller models when retrieving calendar/schedule timeline data.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: