Add Hikvision Video Loss binary sensor#172005
Open
ptarjan wants to merge 1 commit into
Open
Conversation
The pyhik library emits a "Video Loss" sensor type (mapped from `videoloss`), but it was missing from `BINARY_SENSOR_DESCRIPTIONS`, so users with that event source saw a noisy "Unknown Hikvision sensor type 'Video Loss'" warning and no entity. Reported in home-assistant#165422. https://claude.ai/code/session_01DuwvgknKWrDWqtYDnWmCHP
home-assistant
Bot
added
bugfix
integration: hikvision
small-pr
Contributor
|
Hey there @mezz64, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for a new Hikvision diagnostic binary sensor representing “Video loss”.
Changes:
- Introduces a new
video_losstranslation string for the Hikvision integration. - Registers a new
BinarySensorEntityDescriptionmapping for the “Video Loss” event as a diagnostic/problem entity.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| homeassistant/components/hikvision/strings.json | Adds the video_loss translation key to display a localized sensor name. |
| homeassistant/components/hikvision/binary_sensor.py | Adds a new binary sensor description for the “Video Loss” event. |
Comment on lines
+106
to
+111
| "Video Loss": BinarySensorEntityDescription( | ||
| key="video_loss", | ||
| translation_key="video_loss", | ||
| device_class=BinarySensorDeviceClass.PROBLEM, | ||
| entity_category=EntityCategory.DIAGNOSTIC, | ||
| ), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
The
pyhiklibrary emits aVideo Losssensor type (mapped from thevideolosskey inSENSOR_MAP), butBINARY_SENSOR_DESCRIPTIONSinhikvision/binary_sensor.pywas missing an entry for it. As a result,users with that event source saw a noisy warning on every setup —
— and no entity was created.
This PR adds the missing description with
device_class=PROBLEMandEntityCategory.DIAGNOSTIC, matching the pattern of the neighboringdiagnostic entries (
Bad Video,Video Mismatch,Recording Failure),plus the corresponding translation in
strings.json.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: