Trigger active scan when picking a rapt_ble device in the config flow#172054
Open
bdraco wants to merge 1 commit into
Open
Trigger active scan when picking a rapt_ble device in the config flow#172054bdraco wants to merge 1 commit into
bdraco wants to merge 1 commit into
Conversation
home-assistant
Bot
added
bugfix
cla-signed
has-tests
integration: rapt_ble
small-pr
Contributor
|
Hey there @sairon, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
Ensures the rapt_ble config flow’s manual device picker shows up-to-date nearby devices by forcing an on-demand Bluetooth active scan before reading cached discovery results.
Changes:
- Trigger
bluetooth.async_request_active_scan(self.hass)during theuserstep before iteratingasync_discovered_service_info. - Extend config flow tests to assert an active scan is requested when starting the user flow with found devices.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
homeassistant/components/rapt_ble/config_flow.py |
Requests an on-demand active scan before building the list of selectable devices in the user step. |
tests/components/rapt_ble/test_config_flow.py |
Adds a patch/assertion verifying the config flow requests an active scan when showing the device picker. |
Comment on lines
+96
to
99
| patch( | ||
| "homeassistant.components.rapt_ble.config_flow.bluetooth.async_request_active_scan" | ||
| ) as mock_request_active_scan, | ||
| ): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
With the new AUTO scanning default the scanner sits passive between sweeps, so the manual user picker can be empty or stale when opened. Trigger a one shot active scan via bluetooth.async_request_active_scan before reading the cached service info, so the picker shows what is actually nearby.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: