Skip to content

Show device name tip with link to editor, disable update button when state is clean#52024

Open
timmo001 wants to merge 5 commits into
devfrom
entity-settings-dirty-state-plus-tip
Open

Show device name tip with link to editor, disable update button when state is clean#52024
timmo001 wants to merge 5 commits into
devfrom
entity-settings-dirty-state-plus-tip

Conversation

@timmo001
Copy link
Copy Markdown
Member

@timmo001 timmo001 commented May 13, 2026 •
edited
Loading

Breaking change

Proposed change

For #51683

Also checks dirty state of editor, so update button is disabled until changes are actually made

Screenshots

Original commit with tip in a popover, needed work for focus loss, but ultimately felt too intrusive
screenrecording-2026-05-13_12-16-32.mp4

Simplified using helper slot (this text is tiny, but it's the default, ha-input redesign could help improve here)

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • I have followed the perfect PR recommendations
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

To help with the load of incoming pull requests:

@timmo001 timmo001 added the Needs UX Items requiring a review from the Home Assistant design team label May 13, 2026
@timmo001
Copy link
Copy Markdown
Member Author

timmo001 commented May 13, 2026 •
edited
Loading

Need guidance on the wording here. Currently:

Consider renaming the device instead to update all its entities at once. Open device settings

@timmo001 timmo001 marked this pull request as ready for review May 13, 2026 11:30
@timmo001 timmo001 changed the title Disable update button when state is clean Disable update button when state is clean, show device tip with link to editor May 13, 2026
@timmo001 timmo001 changed the title Disable update button when state is clean, show device tip with link to editor Disable update button when state is clean, show device name tip with link to editor May 13, 2026
@timmo001 timmo001 changed the title Disable update button when state is clean, show device name tip with link to editor Show device name tip with link to editor, disable update button when state is clean, May 13, 2026
@timmo001 timmo001 changed the title Show device name tip with link to editor, disable update button when state is clean, Show device name tip with link to editor, disable update button when state is clean May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla-signed Needs UX Items requiring a review from the Home Assistant design team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Promote device renaming over entity renaming in entity settings UI

1 participant

@timmo001