Fix warnings

Author: bgoncal

Sources/App/Assist/Local/SpeechSynthesizer.swift

@@ -12,7 +12,7 @@ protocol SpeechSynthesizerProtocol: AnyObject {
 
 /// A text-to-speech synthesizer using Apple's AVSpeechSynthesizer framework.
 /// Speaks text locally on the device without sending audio data to a server.
-final class SpeechSynthesizer: NSObject, SpeechSynthesizerProtocol, AVSpeechSynthesizerDelegate {
+final class SpeechSynthesizer: NSObject, SpeechSynthesizerProtocol, AVSpeechSynthesizerDelegate, @unchecked Sendable {
     private let synthesizer = AVSpeechSynthesizer()
     private let voice: AVSpeechSynthesisVoice?
 

Sources/App/BarcodeScanner/Camera/BarcodeScannerCamera.swift

@@ -7,7 +7,7 @@ protocol BarcodeScannerCameraDelegate: AnyObject {
     func didDetectBarcode(_ code: String, format: String)
 }
 
-final class BarcodeScannerCamera: NSObject {
+final class BarcodeScannerCamera: NSObject, @unchecked Sendable {
     private let captureSession = AVCaptureSession()
     private var isCaptureSessionConfigured = false
     private var deviceInput: AVCaptureDeviceInput?

Sources/App/ClientEvents/LocationHistoryDetailViewController.swift

@@ -369,8 +369,8 @@ private extension LocationHistoryDetailViewController {
 
 extension LocationHistoryDetailViewController: MKMapViewDelegate {
     func mapView(_ mapView: MKMapView, viewFor annotation: MKAnnotation) -> MKAnnotationView? {
-        let view = MKPinAnnotationView(annotation: annotation, reuseIdentifier: nil)
-        view.pinTintColor = .purple
+        let view = MKMarkerAnnotationView(annotation: annotation, reuseIdentifier: nil)
+        view.markerTintColor = .purple
         return view
     }
 

Sources/App/Frontend/ConnectivityCheck/ConnectivityChecker.swift

@@ -1,5 +1,6 @@
 import Foundation
 import Network
+import os
 
 @MainActor
 class ConnectivityChecker {
@@ -84,7 +85,7 @@ class ConnectivityChecker {
                 }
                 var storage = sockaddr_storage()
                 data.withUnsafeBytes { bytes in
-                    memcpy(&storage, bytes.baseAddress!, min(bytes.count, MemoryLayout<sockaddr_storage>.size))
+                    _ = memcpy(&storage, bytes.baseAddress!, min(bytes.count, MemoryLayout<sockaddr_storage>.size))
                 }
 
                 var hostname = [CChar](repeating: 0, count: Int(NI_MAXHOST))
@@ -140,35 +141,34 @@ class ConnectivityChecker {
                 using: .tcp
             )
 
-            var completed = false
-            let timeoutTask = DispatchWorkItem {
-                if !completed {
-                    completed = true
-                    connection.cancel()
-                    continuation.resume(throwing: NSError(
-                        domain: "ConnectivityChecker",
-                        code: -1,
-                        userInfo: [NSLocalizedDescriptionKey: "Connection timeout"]
-                    ))
+            // Returns true only on the first call, so the continuation is resumed exactly once
+            let completed = OSAllocatedUnfairLock(initialState: false)
+            let markCompleted: @Sendable () -> Bool = {
+                completed.withLock { done in
+                    if done { return false }
+                    done = true
+                    return true
                 }
             }
+            let timeoutTask = DispatchWorkItem {
+                guard markCompleted() else { return }
+                connection.cancel()
+                continuation.resume(throwing: NSError(
+                    domain: "ConnectivityChecker",
+                    code: -1,
+                    userInfo: [NSLocalizedDescriptionKey: "Connection timeout"]
+                ))
+            }
 
             connection.stateUpdateHandler = { state in
-                guard !completed else { return }
-
                 switch state {
                 case .ready:
-                    completed = true
+                    guard markCompleted() else { return }
                     timeoutTask.cancel()
                     connection.cancel()
                     continuation.resume()
-                case let .failed(error):
-                    completed = true
-                    timeoutTask.cancel()
-                    connection.cancel()
-                    continuation.resume(throwing: error)
-                case let .waiting(error):
-                    completed = true
+                case let .failed(error), let .waiting(error):
+                    guard markCompleted() else { return }
                     timeoutTask.cancel()
                     connection.cancel()
                     continuation.resume(throwing: error)

Sources/App/Frontend/DownloadManager/DownloadManagerView.swift

@@ -60,15 +60,25 @@ struct DownloadManagerView: View {
         }
     }
 
-    private var successView: some View {
-        VStack(spacing: DesignSystem.Spaces.three) {
-            Image(systemSymbol: .checkmark)
-                .foregroundStyle(.green)
-                .font(.system(size: 100))
+    @ViewBuilder
+    private var successCheckmark: some View {
+        let checkmark = Image(systemSymbol: .checkmark)
+            .foregroundStyle(.green)
+            .font(.system(size: 100))
+        if #available(iOS 18, *) {
+            checkmark
                 .symbolEffect(
                     .bounce,
                     options: .nonRepeating
                 )
+        } else {
+            checkmark
+        }
+    }
+
+    private var successView: some View {
+        VStack(spacing: DesignSystem.Spaces.three) {
+            successCheckmark
             Text(verbatim: L10n.DownloadManager.Finished.title)
                 .font(.title.bold())
             if let url = viewModel.lastURLCreated {

Sources/App/Frontend/DownloadManager/DownloadManagerViewModel.swift

@@ -57,8 +57,11 @@ extension DownloadManagerViewModel: WKDownloadDelegate {
             }
             progressObservation?.invalidate()
             progressObservation = download.progress.observe(\.completedUnitCount) { [weak self] progress, _ in
-                guard let self else { return }
-                self.progress = bytesToMBString(progress.completedUnitCount)
+                let completedUnitCount = progress.completedUnitCount
+                Task { @MainActor [weak self] in
+                    guard let self else { return }
+                    self.progress = bytesToMBString(completedUnitCount)
+                }
             }
             return url
         } else {

Sources/App/Frontend/Extensions/WebViewGestureHandler.swift

@@ -43,6 +43,7 @@ final class WebViewGestureHandler {
     private func showSidebar() {
         webView?.webViewExternalMessageHandler
             .sendExternalBus(message: .init(command: WebViewExternalBusOutgoingMessage.showSidebar.rawValue))
+            .cauterize()
     }
 
     private func webViewNavigateBack() {

Sources/App/Onboarding/API/OnboardingAuthStepClientCertificate.swift

@@ -110,9 +110,9 @@ final class OnboardingAuthStepClientCertificate: OnboardingAuthPreStep {
 
             DispatchQueue.main.async {
                 let view = ClientCertificateOnboardingView(
-                    onImport: { [weak self] certificate in
+                    onImport: { certificate in
                         Current.Log.info("[mTLS] Certificate imported: \(certificate.displayName)")
-                        self?.authDetails.clientCertificate = certificate
+                        self.authDetails.clientCertificate = certificate
                         sender.dismiss(animated: true) {
                             seal.fulfill(())
                         }

Sources/App/Onboarding/Views/OnboardingErrorView.swift

@@ -36,7 +36,7 @@ struct OnboardingErrorView: View {
             viewAppeared = true
         }
         .sheet(isPresented: $showShareSheet, content: {
-            ShareActivityView(activityItems: [Current.Log.archiveURL()])
+            ShareActivityView(activityItems: [Current.Log.archiveURL()].compactMap { $0 })
         })
     }
 

Sources/App/Scenes/CarPlaySceneDelegate.swift

@@ -227,7 +227,9 @@ class CarPlaySceneDelegate: UIResponder {
 
     private func observeCarPlayConfigChanges() {
         configObservation?.cancel()
-        let observation = ValueObservation.tracking(CarPlayConfig.fetchOne)
+        let observation = ValueObservation.tracking { db in
+            try CarPlayConfig.fetchOne(db)
+        }
         configObservation = observation.start(
             in: Current.database(),
             onError: { error in