Revert "Defer missing-image autofix until after setup completes"

This reverts commit 183e66f.

Author: agners

supervisor/apps/app.py

@@ -262,9 +262,9 @@ async def load(self) -> None:
         except DockerNotFound:
             _LOGGER.info("No %s app Docker image %s found", self.slug, self.image)
             if self.need_build:
-                # Build apps potentially take a long time to set up. Surface
-                # a repair so the resolution autofix loop handles the build
-                # after setup completes instead of blocking it.
+                # Don't run a local build during setup. Surface a repair so
+                # the resolution autofix loop can handle it off the critical
+                # path.
                 self._create_missing_image_issue()
             else:
                 try:
@@ -275,10 +275,9 @@ async def load(self) -> None:
                     self._create_missing_image_issue()
         except DockerError as err:
             # Docker error other than a clean "image not found" - we can't
-            # tell whether the image is actually missing. Log so the issue
-            # is visible (CRITICAL is captured by the Sentry integration)
-            # and leave the app detached; the user can attempt a manual
-            # repair from the UI once the underlying cause is resolved.
+            # tell whether the image is actually missing. Log and leave the
+            # addon detached; a future load will reattempt and surface a
+            # MISSING_IMAGE repair if appropriate.
             _LOGGER.critical(
                 "Docker error loading app %s, leaving detached: %s", self.slug, err
             )

supervisor/resolution/fixups/app_execute_repair.py

@@ -2,7 +2,6 @@
 
 import logging
 
-from ...const import CoreState
 from ...coresys import CoreSys
 from ...exceptions import (
     DockerBuildError,
@@ -86,9 +85,4 @@ def issues(self) -> list[IssueType]:
     @property
     def auto(self) -> bool:
         """Return if a fixup can be apply as auto fix."""
-        # Defer auto-repair until setup completes so a missing image (which
-        # for build apps means a potentially slow Docker build) doesn't keep
-        # the system in setup state.
-        return (
-            self.sys_core.state != CoreState.SETUP and self.attempts < MAX_AUTO_ATTEMPTS
-        )
+        return self.attempts < MAX_AUTO_ATTEMPTS

tests/resolution/fixup/test_app_execute_repair.py

@@ -7,7 +7,6 @@
 import pytest
 
 from supervisor.apps.app import App
-from supervisor.const import CoreState
 from supervisor.coresys import CoreSys
 from supervisor.docker.app import DockerApp
 from supervisor.docker.interface import DockerInterface
@@ -101,14 +100,3 @@ async def test_fixup_image_exists(
     with patch.object(DockerApp, "install") as install:
         await app_execute_repair()
         install.assert_not_called()
-
-
-async def test_fixup_skipped_during_setup(coresys: CoreSys):
-    """Test fixup is not auto-applied while Supervisor is still in setup."""
-    app_execute_repair = FixupAppExecuteRepair(coresys)
-
-    await coresys.core.set_state(CoreState.SETUP)
-    assert app_execute_repair.auto is False
-
-    await coresys.core.set_state(CoreState.RUNNING)
-    assert app_execute_repair.auto is True