Node selector for TalosUpgrade

[sergelogvinov]

Hello, thank you for the project.

What do you think to add node selector for TalosUpgrade resource

apiVersion: tuppr.home-operations.com/v1alpha1
kind: TalosUpgrade
metadata:
  name: talos
spec:
  talos:
    version: v1.12.1

  # New option
  nodeSelector:
    node-role.kubernetes.io/worker: ""

It helps to upgrade or reboot only specific nodes in the cluster. Some bare-metal nodes depend heavily on specific kernel modules, and if a new kernel does not include them, we may lose the node after a reboot.

Thanks.

[evgkrsk]

We have same request for KubernetesUpgrade resource, to touch only subset of large cluster in one time.

[onedr0p]

@evgkrsk with the way taloctl handles kubernetes version upgrades, the kubernetes upgrade is an all nodes or no nodes type upgrade.

[sergelogvinov]

Proposal of config:

Very simple to implement, but it probably requires adding a label to the nodes that are under Tuppr control:

spec:
  nodeSelector:
    tuppr: upgrade-me

Or like Talos CCM way:

spec:
  nodeSelector:
    - matchExpressions:
        - key: label-name
          operator: In
          values:
            - value-1
            - value-2

Which way do you think is best?

[onedr0p]

The second way, and if you look thru the commit history this feature did exist at one point 😅 but it was removed to keep things simple.

[sergelogvinov]

Oh thanks, d0b59de

Is this because the cluster supports locking only a single config at a time?