Error when using subdirectories in app/campaigns/

[joshuap]

Creating a new issue here for when I have time to investigate.

See #145 (comment)

[MSeneadza]

So I recently started using Heya and I just ran into this in development mode. I also get an empty array for Heya.campaigns in development but in production I get my actual list of defined campaigns. I haven't seen the relation "heya_steps" does not exist error in production either. I asked my AI about this and it told me:

This is a Rails eager loading difference.
In development, Rails lazy-loads code — campaign classes are only loaded when a file is first referenced/required. If nothing has triggered those campaign files to load yet, the classes haven't been defined, so register_campaign was never called, and Heya.campaigns is empty.

In production, Rails eager-loads everything at boot (config.eager_load = true), so all campaign classes are loaded immediately, their class bodies execute, and each one calls register_campaign on itself during loading.

It suggested that I force eager loading in development, so as a test I added the following to my Heya initializer and it solved both issues:

Rails.application.config.after_initialize do
  Rails.application.eager_load! unless Rails.application.config.eager_load
end

[joshuap]

So I recently started using Heya and I just ran into this in development mode. I also get an empty array for Heya.campaigns in development but in production I get my actual list of defined campaigns. I haven't seen the relation "heya_steps" does not exist error in production either. I asked my AI about this and it told me:

This is a Rails eager loading difference.
In development, Rails lazy-loads code — campaign classes are only loaded when a file is first referenced/required. If nothing has triggered those campaign files to load yet, the classes haven't been defined, so register_campaign was never called, and Heya.campaigns is empty.
In production, Rails eager-loads everything at boot (config.eager_load = true), so all campaign classes are loaded immediately, their class bodies execute, and each one calls register_campaign on itself during loading.

It suggested that I force eager loading in development, so as a test I added the following to my Heya initializer and it solved both issues:

Rails.application.config.after_initialize do
  Rails.application.eager_load! unless Rails.application.config.eager_load
end

Thanks for the context! I don't recommend keeping that in your initializer as the solution, but this reminded me that we do some special eager loading stuff in our Rails engine, and I think the issue is that it's not including subdirectories here:

heya/lib/heya/engine.rb

Lines 13 to 29 in 5ac8b74

	config.to_prepare do
	# This runs the first time *before* Rails is initialized. Because
	# campaigns depend on Rails initialization, we use the `after_initialize`
	# hook when Rails first starts up, and then `to_prepare` when reloading
	# in development. See https://github.com/honeybadger-io/heya/issues/211
	if ::Rails.application.initialized?
	Dir.glob(Rails.root + "app/campaigns/*.rb").each do |c|
	require_dependency(c)
	end
	end
	end
	config.after_initialize do
	Dir.glob(Rails.root + "app/campaigns/*.rb").each do |c|
	require_dependency(c)
	end
	end