Skip to content

Commit c38b8d5

Browse files
authored
Remove padding_index from models that don't use it for better Transformers v5 compatibility (vllm-project#35189)
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
1 parent 60da0e1 commit c38b8d5

14 files changed

Lines changed: 0 additions & 14 deletions

vllm/model_executor/models/ernie45_moe.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -421,7 +421,6 @@ def __init__(self, *, vllm_config: VllmConfig, prefix: str = ""):
421421
cache_config = vllm_config.cache_config
422422
quant_config = vllm_config.quant_config
423423

424-
self.padding_idx = config.pad_token_id
425424
self.vocab_size = config.vocab_size
426425
self.config = config
427426
parallel_config = vllm_config.parallel_config

vllm/model_executor/models/ernie45_vl_moe.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -523,7 +523,6 @@ def __init__(self, *, vllm_config: VllmConfig, prefix: str = ""):
523523
cache_config = vllm_config.cache_config
524524
quant_config = vllm_config.quant_config
525525

526-
self.padding_idx = config.pad_token_id
527526
self.vocab_size = config.vocab_size
528527
self.config = config
529528

vllm/model_executor/models/granitemoeshared.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,6 @@ def __init__(self, *, vllm_config: VllmConfig, prefix: str = ""):
157157

158158
self.config = config
159159
self.quant_config = quant_config # Required by MixtralModel
160-
self.padding_idx = config.pad_token_id
161160

162161
self.vocab_size = config.vocab_size
163162

vllm/model_executor/models/grok1.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,6 @@ def __init__(
451451

452452
self.config = config
453453
self.quant_config = quant_config
454-
self.padding_idx = config.pad_token_id
455454

456455
# Store expert naming for weight loading
457456
self.ckpt_gate_proj_name = ckpt_gate_proj_name

vllm/model_executor/models/hunyuan_v1.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -600,7 +600,6 @@ def __init__(self, *, vllm_config: VllmConfig, prefix: str = ""):
600600

601601
self.config = config
602602
self.quant_config = quant_config
603-
self.padding_idx = config.pad_token_id
604603

605604
self.vocab_size = config.vocab_size
606605

vllm/model_executor/models/jais2.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,6 @@ def __init__(
305305

306306
self.config = config
307307
self.quant_config = quant_config
308-
self.padding_idx = config.pad_token_id
309308

310309
self.vocab_size = config.vocab_size
311310
self.org_vocab_size = config.vocab_size

vllm/model_executor/models/kimi_linear.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -393,7 +393,6 @@ def __init__(self, *, vllm_config: VllmConfig, prefix: str = ""):
393393
parallel_config = vllm_config.parallel_config
394394
self.config = config
395395

396-
self.padding_idx = config.pad_token_id
397396
self.vocab_size = config.vocab_size
398397

399398
if get_pp_group().is_first_rank:

vllm/model_executor/models/longcat_flash.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -486,7 +486,6 @@ def __init__(self, *, vllm_config: VllmConfig, prefix: str = ""):
486486
quant_config = vllm_config.quant_config
487487
self.config = config
488488

489-
self.padding_idx = getattr(config, "pad_token_id", None)
490489
self.vocab_size = config.vocab_size
491490

492491
if get_pp_group().is_first_rank:

vllm/model_executor/models/minimax_text_01.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -495,7 +495,6 @@ def __init__(self, *, vllm_config: VllmConfig, prefix: str = ""):
495495
cache_config = vllm_config.cache_config
496496
scheduler_config = vllm_config.scheduler_config
497497

498-
self.padding_idx = config.pad_token_id
499498
self.vocab_size = config.vocab_size
500499

501500
self.decoder_attention_types = getattr(

vllm/model_executor/models/nemotron_nas.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,6 @@ def __init__(
241241

242242
self.config = config
243243
self.quant_config = quant_config
244-
self.padding_idx = config.pad_token_id
245244

246245
self.vocab_size = config.vocab_size
247246

0 commit comments

Comments
 (0)