fix(aws-lambda): add missing lambda authorizer context type#4908
Open
lihan3238 wants to merge 1 commit into
Open
fix(aws-lambda): add missing lambda authorizer context type#4908lihan3238 wants to merge 1 commit into
lihan3238 wants to merge 1 commit into
Conversation
The Authorizer interface in ApiGatewayRequestContextV2 only included the iam field, missing the lambda field used by custom Lambda authorizers on AWS HTTP API Gateway v2. Fixes honojs#3281
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lambda?: Record<string, unknown>to theAuthorizerinterface insrc/adapter/aws-lambda/types.tsrequestContext.authorizer.lambdawhen using custom Lambda authorizers with AWS HTTP API Gateway v2Background
The
Authorizerinterface used byApiGatewayRequestContextV2only had theiamfield for IAM-based authorization. Custom Lambda authorizers return their context underrequestContext.authorizer.lambda, but this field was missing from the type definition, causing TypeScript errors.Fixes #3281
Test plan