Support Auto-Discovery / Fix missing lib for testing / Upgrade phpunit / Make it compatible with PHP 7.2 (#31)

* Check if joins is not null due to PHP 7.2 bug that crashes when counting null

* Fix missing libraries and upgrade phpunit

* Add php 7.2 to travis

* Support Auto-Discovery

* Remove compatibility with 5.6 and 7.0

* Revert minimum PHP version requirement to 5.4.0

Author: stephane-monnot

.travis.yml

@@ -1,8 +1,8 @@
 language: php
 
 php:
-  - 5.6
-  - 7.0
+  - 7.1
+  - 7.2
 
 sudo: false
 

README.md

@@ -23,8 +23,7 @@ First, install the package through Composer.
 composer require hootlex/laravel-moderation
 ```
 
-Then include the service provider inside `config/app.php`.
-
+If you are using Laravel < 5.5, you need to add Hootlex\Moderation\ModerationServiceProvider to your `config/app.php` providers array:
 ```php
 'providers' => [
     ...

composer.json

@@ -1,7 +1,12 @@
 {
   "name": "hootlex/laravel-moderation",
   "description": "A simple Content Moderation System for Laravel 5.* that allows you to Approve or Reject resources like posts, comments, users, etc.",
-  "keywords": ["laravel", "moderation", "moderation-system", "content-moderation"],
+  "keywords": [
+    "laravel",
+    "moderation",
+    "moderation-system",
+    "content-moderation"
+  ],
   "license": "MIT",
   "authors": [
     {
@@ -19,12 +24,20 @@
     "php": ">=5.4.0"
   },
   "require-dev": {
-    "phpunit/phpunit" : "5.*",
-    "laravel/laravel": "5.*"
+    "phpunit/phpunit": "7.0",
+    "laravel/laravel": "5.*",
+    "nunomaduro/collision": "^2.0"
   },
   "autoload": {
     "psr-4": {
       "Hootlex\\Moderation\\": "src/"
     }
+  },
+  "extra": {
+    "laravel": {
+      "providers": [
+        "Hootlex\\Moderation\\ModerationServiceProvider"
+      ]
+    }
   }
 }

src/ModerationScope.php

@@ -317,7 +317,7 @@ protected function addPend(Builder $builder)
      */
     protected function getStatusColumn(Builder $builder)
     {
-        if (count($builder->getQuery()->joins) > 0) {
+        if ($builder->getQuery()->joins && count($builder->getQuery()->joins) > 0) {
             return $builder->getModel()->getQualifiedStatusColumn();
         } else {
             return $builder->getModel()->getStatusColumn();

tests/ModerationScopeTest.php

@@ -68,12 +68,6 @@ public function it_returns_only_pending_stories()
         }
     }
 
-    /** @test */
-    public function it_returns_only_postponed_stories()
-    {
-
-    }
-
     /** @test */
     public function it_returns_stories_including_pending_ones()
     {