From 51ca907c25dc7a82f1ea7c7d8b45b616b655e94c Mon Sep 17 00:00:00 2001
From: Danny Bendelman <dbendelman@users.noreply.github.com>
Date: Thu, 5 Jun 2025 16:00:07 -0400
Subject: [PATCH] Set service type dynamically based on values

Updated the service template to use `.Values.service.type` directly instead of a ternary operation. This change ensures better flexibility and aligns with user-defined configurations, particularly for LoadBalancer settings.
---
 charts/shc/templates/service.yaml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/charts/shc/templates/service.yaml b/charts/shc/templates/service.yaml
index fec7d9c..00ad172 100644
--- a/charts/shc/templates/service.yaml
+++ b/charts/shc/templates/service.yaml
@@ -9,9 +9,9 @@ metadata:
   annotations:
     {{- toYaml .Values.service.annotations | nindent 4 }}
 spec:
-  type: {{ ternary "ClusterIP" "LoadBalancer" .Values.service.ingress.enabled }}
+  type: {{ .Values.service.type }}
   
-  {{- if not .Values.service.ingress.enabled }}
+  {{- if eq .Values.service.type "LoadBalancer" }}
   loadBalancerIP: {{ .Values.global.externalIP }}
   externalTrafficPolicy: Cluster
   {{- end }}
@@ -40,4 +40,4 @@ spec:
   {{- end }}
   
   selector:
-    app: {{ .Values.service.selector.app }}
\ No newline at end of file
+    app: {{ .Values.service.selector.app }}