chore: support hyphens for handles

Author: Darlington02

src/namespaces/handles.cairo

@@ -76,6 +76,7 @@ pub mod Handles {
     const ASCII_0: u8 = 48;
     const ASCII_9: u8 = 57;
     const ASCII_UNDERSCORE: u8 = 95;
+    const ASCII_HYPHEN: u8 = 45;
 
     // *************************************************************************
     //                            EVENTS
@@ -270,7 +271,7 @@ pub mod Handles {
         }
 
         /// @notice validates that a local name contains only [a-z,0-9,_] and does not begin with an
-        /// underscore.
+        /// underscore or hyphen.
         /// @param local_name username to be minted
         fn _validate_local_name(self: @ContractState, local_name: felt252) {
             let mut value: u256 = local_name.into();
@@ -282,7 +283,9 @@ pub mod Handles {
                 }
                 last_char = (value & 0xFF).try_into().unwrap();
                 assert(
-                    (self._is_alpha_numeric(last_char) || last_char == ASCII_UNDERSCORE),
+                    (self._is_alpha_numeric(last_char)
+                        || last_char == ASCII_UNDERSCORE
+                        || last_char == ASCII_HYPHEN),
                     Errors::INVALID_LOCAL_NAME
                 );
 
@@ -291,7 +294,10 @@ pub mod Handles {
 
             // Note that for performance reason, the local_name is parsed in reverse order,
             // so the first character is the last processed one.
-            assert(last_char != ASCII_UNDERSCORE.into(), Errors::INVALID_LOCAL_NAME);
+            assert(
+                last_char != ASCII_UNDERSCORE.into() && last_char != ASCII_HYPHEN.into(),
+                Errors::INVALID_LOCAL_NAME
+            );
         }
 
         // @notice checks that a character is alpha numeric

tests/test_handle.cairo

@@ -20,9 +20,10 @@ const TEST_LOCAL_NAME: felt252 = 'coloniz';
 const TEST_LOCAL_NAME_TWO: felt252 = 'coloniz_two';
 const TEST_LOCAL_NAME_THREE: felt252 = 'colonizdoe_';
 const TEST_LOCAL_NAME_FOUR: felt252 = 'colonizdoe2';
+const TEST_LOCAL_NAME_FIVE: felt252 = 'coloniz-doe2';
 const TEST_BAD_LOCAL_NAME_1: felt252 = '_coloniz';
 const TEST_BAD_LOCAL_NAME_2: felt252 = 'Coloniz';
-const TEST_BAD_LOCAL_NAME_3: felt252 = 'coloniz-';
+const TEST_BAD_LOCAL_NAME_3: felt252 = '-coloniz';
 
 const TEST_TOKEN_ID: u256 =
     3382571571946029498300446473584208976610422898231982587356291365654797409289;
@@ -60,6 +61,17 @@ fn test_mint_handle_two() {
     assert(local_name == TEST_LOCAL_NAME_TWO, 'invalid local name two');
 }
 
+fn test_mint_handle_supports_hyphens() {
+    let handles_contract_address = __setup__();
+    let handles_dispatcher = IHandleDispatcher { contract_address: handles_contract_address };
+
+    let token_id = handles_dispatcher
+        .mint_handle(TEST_LOCAL_NAME_FIVE, USER_ONE.try_into().unwrap());
+
+    let local_name: felt252 = handles_dispatcher.get_local_name(token_id);
+    assert(local_name == TEST_LOCAL_NAME_FIVE, 'invalid local name five');
+}
+
 #[test]
 #[should_panic(expected: ('coloniz: invalid local name!',))]
 fn test_mint_handle_with_bad_local_name_1() {
@@ -68,6 +80,7 @@ fn test_mint_handle_with_bad_local_name_1() {
 
     handles_dispatcher.mint_handle(TEST_BAD_LOCAL_NAME_1, USER_ONE.try_into().unwrap());
 }
+
 #[test]
 #[should_panic(expected: ('coloniz: invalid local name!',))]
 fn test_mint_handle_with_bad_local_name_2() {