HGI-8599: Fix counter value issue in sync_stream (#171)

Author: mianazmatali9

tap_quickbooks/__init__.py

@@ -256,8 +256,8 @@ def do_sync(qb, catalog, state, state_passed):
                                               catalog_entry['tap_stream_id'],
                                               'version',
                                               stream_version)
-            counter = sync_stream(qb, catalog_entry, state, state_passed)
-            LOGGER.info("%s: Completed sync (%s rows)", stream_name, counter.value)
+            counter_value = sync_stream(qb, catalog_entry, state, state_passed)
+            LOGGER.info("%s: Completed sync (%s rows)", stream_name, counter_value)
 
     state["current_stream"] = None
     singer.write_state(state)
@@ -334,4 +334,4 @@ def main():
 
 if __name__ == "__main__":
     atexit.register(cleanup)
-    main()
+    main()

tap_quickbooks/quickbooks/rest.py

@@ -108,7 +108,7 @@ def _sync_records(self, url, headers, params, stream):
 
         query = params['query']
 
-        def sync_records(query):            
+        def sync_records(query, is_deleted=False):            
             offset = 0
             max = 100
             page = 0
@@ -122,8 +122,12 @@ def sync_records(query):
                 # Establish number of records returned.
                 count = resp_json['QueryResponse'].get('maxResults', 0)
 
-                # Make sure there is alteast one record.
+                # Make sure there is at least one record.
                 if count == 0:
+                    if is_deleted:
+                        LOGGER.info(f"Response (deleted) with no data {resp_json}")
+                    else:
+                        LOGGER.info(f"Response with no data {resp_json}")
                     break;
 
                 page += 1
@@ -147,4 +151,4 @@ def sync_records(query):
                 query_deleted = query.replace("WHERE", "where Active = false and")
             else:
                 query_deleted = f"{query} where Active = false" 
-            yield from sync_records(query_deleted)
+            yield from sync_records(query_deleted, is_deleted=True)

tap_quickbooks/sync.py

@@ -60,6 +60,7 @@ def get_stream_version(catalog_entry, state):
 
 def sync_stream(qb, catalog_entry, state, state_passed):
     stream = catalog_entry['stream']
+    counter_value = 0
 
     with metrics.record_counter(stream) as counter:
         try:
@@ -76,7 +77,9 @@ def sync_stream(qb, catalog_entry, state, state_passed):
             raise Exception("Error syncing {}: {}".format(
                 stream, ex)) from ex
 
-        return counter
+        counter_value = counter.value
+
+    return counter_value
 
 
 def sync_records(qb, catalog_entry, state, counter, state_passed):