Contribution status bar doesn't update in some projects

[manjitapandey]

Describe the bug
The horizontal bar on project card, project page and tasks page doesn't update sometimes with the tasks status update. I have mapped and validated every tasks on a project with no bad imageries. but when i see the progress bar, it shows only 95% of tasks has been validated.

To Reproduce
Steps to reproduce the behavior:

1. Go to 'https://tasks.hotosm.org/projects/16531
2. Click on 'contribute'
3. See all projects mapped and validated but not updated on contributions bar error.

Expected behavior
The status of contribution bar should be updated according to the number of tasks mapped and validated.

Screenshots

[anthaas]

This bug is hard to review later in time. Because after a while (let's say the next day) the information is presented correctly.
So in my experience how to reproduce the bug is to take any project, make all the validation done and immediately after that start to examine the status of the project in the dashboard, in the project description and in the tasks overview (even after the hard reload of the browser). Please note that I also reviewed the status of the tasks in the stats page of the project saying that all of the tasks were finished and 0 tasks were waiting to be mapped or validated or have been in the unavailable status.

See the screenshots

[prabinoid]

The 95% completion rate aligns with the fact that tasks 25, 68, and 71 of this project are yet to be validated. While it may appear that all tasks are validated on the map, these particular tasks might be hidden or not displayed properly.

[anthaas]

Hi, thanks @prabinoid, your statement is related to the project https://tasks.hotosm.org/projects/16531/stats/. That's also reason why I've added my comment and the screenshots after refreshing the browser (Ctrl+Shift+R) to be sure that stats page shows 100% of the tasks finished. Also as I mentioned, it's hard to review project in the past. Best way to reproduce this bug is to try validate all (for example on the staging site) and immediately after the validation examine the project.
I've tried to use staging site to demonstrate current behavior, but I'm not able to submit multiple validated tasks at once to prepare the 'after status' of the project for screenshots.

[anthaas]

Now I was able to reproduce it exactly with the staging site and the testing project https://tasks-stage.hotosm.org/projects/14937

before

and after the validation and reloading all the pages

As you can see,

1. the stats page https://tasks-stage.hotosm.org/projects/14937/stats/ says that every mapped task is validated - OK
2. the tasks tab https://tasks-stage.hotosm.org/projects/14937/tasks says that my last contribution was 1 minute ago - OK
3. the project overview https://tasks-stage.hotosm.org/projects/14937 displays correctly that everything is validated, but the last contribution time is wrong - NOT OK
4. the explore page (projects dashboard) https://tasks-stage.hotosm.org/explore wrongly displays that there are tasks to be validated - NOT OK

[spwoodcock]

I only had a cursory look at this, so apologies if I just add noise.

Managed to hone in on the exact code used here:
On the frontend side I believe it is:

tasking-manager/frontend/src/components/projectDetail/infoPanel.js

Line 55 in 505acfa

lastUpdated={project.lastUpdated}

As it's using project.lastUpdated, this suggests to me that the 'Last Contribution xxx' stat is taken from when the project was last updated, not from when the last contribution was made.

The project.last_updated field on the backend is updated with a current timestamp each time the project is updated:

tasking-manager/backend/models/postgis/project.py

Line 425 in 505acfa

self.last_updated = timestamp()

If we view the response for the project, we see that the lastUpdated field is set to 2024-11-27, around two weeks ago:
https://tasking-manager-tm4-production-api.hotosm.org/api/v2/projects/17948/

This could account for the discrepancy: the field is looking for the last update to the project, but not searching for the last contribution date (from task events or comments).

Please correct me if I am wrong!

[spwoodcock]

There could be other ways to determine the last contribution date, without relying on the project.last_updated field.

We already get contributions by date for mapping and validation for an API call on this page:
https://tasking-manager-tm4-production-api.hotosm.org/api/v2/projects/17948/contributions/queries/day/

The API only returns days where there was a task mapping or validation event.
Can we just take the most recent date from here?

Open to ideas @prabinoid @royallsilwallz !

Alternatively we can ensure the backend always updates the project.updated_at field when a contribution is made, but this seems like a bad approach to me, prone to database locking issues and race conditions.

[Pseudorandom-Pseudonym]

@spwoodcock what counts as updating a project?

[spwoodcock]

Current implementation

• Whenever the projects table in the database is modified, the last_updated field will be automatically updated (to a current timestamp).

• So when the fields such as percentage_mapped etc are calculated and inserted via the backend, the project will have a new last_updated timestamp set.

What counts as a project update

• Good question - I think the devs working on TM would have a better idea of the criteria 😃

• My hunch would be when a task is updated in a project (status change or comment), then we should count this as a project update.

Do you have any thoughts?