-
Notifications
You must be signed in to change notification settings - Fork 365
Open
Description
Description
After upgrading from v2.0.20 to v2.0.21, closing a <dialog> element triggers a Turbo Frame refetch of the underlying page content.
Steps to Reproduce
- Navigate to a page with Turbo Frames
- Open a modal dialog (using
<dialog>withshowModal()) - Close the dialog (via
.close()or removing the element) - Observe: The Turbo Frame refetches its content (and all associated assets)
Network Activity on Dialog Close
- plans 200 fetch frame_ant.js:2
- actiontext-.css 200 stylesheet
- application-.css 200 stylesheet
- ... (all page assets reload)
Expected Behavior
Closing a dialog should not trigger any Turbo Frame refetches.
Actual Behavior
The Turbo Frame refetches its src URL when the dialog is closed/removed.
Versions
- turbo-rails: 2.0.21 (works correctly in 2.0.20)
- Rails: 8.1.2
- Browser: Chrome
Possible Cause
This may be related to #740 ("Include hidden elements for turbo-cable-stream-source selector").
Workaround
Pinning to gem "turbo-rails", "2.0.20" resolves the issue.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels