Adds advanced option to disable update version features (#1639)

Author: hovancik

CHANGELOG.md

@@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 ### Added
 - Yiddish and Tamil translations
 - advanced option to show custom message in Preferences
+- advanced option to disable app update features
 
 ### Changed
 - remove flags in Welcome window

README.md

@@ -375,7 +375,14 @@ Note that this will disable graphical way of opening Stretchly Preferences. To a
 If you want to show tray menu even while in Strict mode, set `showTrayMenuInStrictMode` to `true`.
 
 #### Show custom message in Preferences
-If you want to show custom message in Preferences, set `customPreferencesMessage` to string of your liking. This might be useful for corporate installations. 
+If you want to show custom message in Preferences, set `customPreferencesMessage` to string of your liking. 
+
+This might be useful for corporate installations. 
+
+#### Disable app update functionality
+If you want to disable functionality around app updates, set `disableAppUpdateFeatures` to `true`. This will make Stretchly not to check for new versions and hide related elements from the app. This value takes preference over `checkNewVersion` and `notifyNewVersion`. 
+
+This might be useful for corporate installations. 
 
 ## Contributor Preferences
 

app/break-renderer.js

@@ -42,10 +42,17 @@ window.onload = async (event) => {
     }
     if (Date.now() - started < duration) {
       const passedPercent = (Date.now() - started) / duration * 100
-      postponeElement.style.display =
-        await window.utils.canPostpone(postpone, passedPercent, postponePercent) ? 'flex' : 'none'
-      closeElement.style.display =
-        await window.utils.canSkip(strictMode, postpone, passedPercent, postponePercent) ? 'flex' : 'none'
+      if (await window.utils.canPostpone(postpone, passedPercent, postponePercent)) {
+        postponeElement.classList.remove('hidden')
+      } else {
+        postponeElement.classList.add('hidden')
+      }
+
+      if (await window.utils.canSkip(strictMode, postpone, passedPercent, postponePercent)) {
+        closeElement.classList.remove('hidden')
+      } else {
+        closeElement.classList.add('hidden')
+      }
       progress.value = (100 - passedPercent) * progress.max / 100
       progressTime.innerHTML = await window.utils.formatTimeRemaining(Math.trunc(duration - Date.now() + started),
         await window.settings.get('language'))

app/break.html

@@ -19,12 +19,12 @@
         <span id='progress-time' aria-hidden="true"></span>
       </div>
       <div>
-        <a id="postpone" class="tooltip top">
+        <a id="postpone" class="tooltip top hidden">
           <span data-i18next="break.postpone"></span>
           <img src="images/breaks/break-postpone.svg" />
           <span class="tiptext"></span>
         </a>
-        <a id="close" class="tooltip top">
+        <a id="close" class="tooltip top hidden">
           <span data-i18next="break.skip"></span>
           <img src="images/breaks/break-skip.svg" />
           <span class="tiptext"></span>

app/css/break.css

@@ -49,10 +49,6 @@
   line-height: 18px;
 }
 
-.breaks > :nth-child(2) > a {
-  display: none;
-}
-
 .breaks > :nth-child(2) > a:hover {
   color: #FFFF00;
 }

app/css/commons.css

@@ -161,6 +161,10 @@ body {
   display: none;
 }
 
+.hidden {
+  display: none !important;
+}
+
 a {
   cursor: pointer;
 }

app/css/preferences.css

@@ -62,11 +62,6 @@ body > div > :last-child {
   z-index: 9;
 }
 
-body > .hidden,
-.heart > .hidden {
-  display: none;
-}
-
 .settings {
   display: grid;
   font-size: 13px;
@@ -367,10 +362,6 @@ body[dir=rtl] .about > :nth-child(4) > div {
   margin: auto 20px;
 }
 
-.about > .debug > :first-child {
-  display: none;
-}
-
 .heart {
   display: grid;
   font-size: 18px;

app/main.js

@@ -542,6 +542,7 @@ function createSyncPreferencesWindow () {
 }
 
 function planVersionCheck (seconds = 1) {
+  if (settings.get('disableAppUpdateFeatures')) return
   if (updateChecker) {
     clearInterval(updateChecker)
     updateChecker = null
@@ -550,6 +551,7 @@ function planVersionCheck (seconds = 1) {
 }
 
 function checkVersion () {
+  if (settings.get('disableAppUpdateFeatures')) return
   if (settings.get('checkNewVersion')) {
     processWin.webContents.send('check-version',
       `v${app.getVersion()}`,
@@ -1126,7 +1128,7 @@ function updateTray () {
 function getTrayMenuTemplate () {
   const trayMenu = []
 
-  if (global.isNewVersion) {
+  if (!settings.get('disableAppUpdateFeatures') && global.isNewVersion) {
     trayMenu.push({
       label: i18next.t('main.downloadLatestVersion'),
       click: function () {

app/microbreak-renderer.js

@@ -41,10 +41,17 @@ window.onload = async (event) => {
     }
     if (Date.now() - started < duration) {
       const passedPercent = (Date.now() - started) / duration * 100
-      postponeElement.style.display =
-        await window.utils.canPostpone(postpone, passedPercent, postponePercent) ? 'flex' : 'none'
-      closeElement.style.display =
-        await window.utils.canSkip(strictMode, postpone, passedPercent, postponePercent) ? 'flex' : 'none'
+      if (await window.utils.canPostpone(postpone, passedPercent, postponePercent)) {
+        postponeElement.classList.remove('hidden')
+      } else {
+        postponeElement.classList.add('hidden')
+      }
+
+      if (await window.utils.canSkip(strictMode, postpone, passedPercent, postponePercent)) {
+        closeElement.classList.remove('hidden')
+      } else {
+        closeElement.classList.add('hidden')
+      }
       progress.value = (100 - passedPercent) * progress.max / 100
       progressTime.innerHTML = await window.utils.formatTimeRemaining(Math.trunc(duration - Date.now() + started),
         await window.settings.get('language'))

app/microbreak.html

@@ -19,12 +19,12 @@
         <span id='progress-time' aria-hidden="true"></span>
       </div>
       <div>
-        <a id="postpone" class="tooltip top">
+        <a id="postpone" class="tooltip top hidden">
           <span data-i18next="break.postpone"></span>
           <img src="images/breaks/break-postpone.svg" />
           <span class="tiptext"></span>
         </a>
-        <a id="close" class="tooltip top">
+        <a id="close" class="tooltip top hidden">
           <span data-i18next="break.skip"></span>
           <img src="images/breaks/break-skip.svg" />
           <span class="tiptext"></span>