[Line Timetable ] timecard edit page + text block

[bbonnesoeur]

Page to edit line time card

tasks

• just a page to edit a simple timecard
• you can add a simple text block

notes

• add / delete a block anywhere in timecard
• handle a rank in block entity (rank field)

[vpassama]

Hi there !

I'm currently coding the edition page for LineTimetable and I have some technical questions. I will bring the questions one by one and I begin with the translator.

translator

We have two different files named 'messages' and 'default' in order to translate text. In my NMM instance, when I write something like this :

{{ text|trans }}

The file used is not 'default' but 'messages'. I would know if it is the same behavior for you or if I missed something in the configuration because it can lead to lot of little mistakes later.

Why am I asking this now ? Because I saw in the base template the place where you declare the pageTitle and it is coded like this :

{{ pageTitle|trans }}

But when I look at the pageTitle value in the different controllers, it seems corresponding to keys declared in 'messages' and 'default' files so sometimes it works and sometimes it doesn't.

grep -r pageTitle *
Controller/StopPointController.php:                'pageTitle'         => "menu.edit_timetables",
Controller/StopTimetableController.php:                'pageTitle'             => 'stop_timetable.titles.' 

So, what should I do about this ? In our own bundles, we have only one file for translation and we used more keys in order to separate translations in a logical way, like this :

bundle:
    menu:
        menu_object1
        menu_object2

    object:
        message:
            key1
            key2
        action:
            key1
        label:
            key1
            key2

Then, we don't have to think about the file where is stored the translation and we can use text|trans without the fear of breaking something. Are you interested in something similar ? We could open a dedicated PR about this if you agree. (you can see our translation file here)

[vpassama]

Hello @datanel :)

I saw lot of useless code in the renderLayout process for stopTimetables. Because you can't edit anymore a stopPoint (but only a stopTimetable), I will delete all the things related to stopPoint / stopPointLevel / blockLevel because they are not really used anymore.

The routes become :

canal_tp_mtt_stop_timetable_edit:
    pattern: /stopTimetable/edit/networks/{externalNetworkId}/line/{externalLineId}/route/{externalRouteId}/seasons/{seasonId}

canal_tp_mtt_stop_timetable_view:
    pattern: /stopTimetable/view/networks/{externalNetworkId}/line/{externalLineId}/route/{externalRouteId}/seasons/{seasonId}/stopPoint/{externalStopPointId}

I need your confirmation and we could create a new PR to clean all these things.

[vpassama]

Hey, I'm waiting for news and in order to pass the time I would speak about some details.

I'm currently cleaning macros, lot of things will change because I delete level / stopPointLevel.

I don't understand why you manage this variable and I delete it from controller but also from the js file used in timetable edition.

We don't need anymore the level but we don't need to bring blockTypes informations from PHP to the template. I use this instead :

{% macro img(id, block, class) %}
    <div
        id="{{ id }}"
        class="block {{ class }}"
        data-type="img"
        data-icon="picture"
    >
        {% if block %}
            <img class="{{ class }}" src="{{ block.content }}" title="{{ block.title }}" alt="{{ block.title }}" />
        {% endif %}
    </div>
{% endmacro %}

You see here, the template just simply declare an icon related to a block.

    var _get_blocks = function()
    {   
        var $blocks = $('.block').each(function() {
            var icon_class = 'glyphicon-'+$(this).data('icon');
            $(this).prepend($icon_tpl.clone().addClass(icon_class));
        }); 

        return $blocks;
    };  

The js file apply the icon related to a specific block.

[vpassama]

@datanel, you can watch the PRs here :

• Timetable entity #88 timetable entity
• Clean stop timetable edition #89 cleaning stopTimetable edition process