From cd8629d3d7dc0ce576b4587b7b4dca61468c9724 Mon Sep 17 00:00:00 2001 From: Marco Maldonado Date: Tue, 23 May 2023 14:47:13 -0700 Subject: [PATCH 1/4] added fix for workplace messages --- packages/botbuilder-adapter-facebook/src/facebook_adapter.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/botbuilder-adapter-facebook/src/facebook_adapter.ts b/packages/botbuilder-adapter-facebook/src/facebook_adapter.ts index b3031bfec..213a43003 100644 --- a/packages/botbuilder-adapter-facebook/src/facebook_adapter.ts +++ b/packages/botbuilder-adapter-facebook/src/facebook_adapter.ts @@ -385,6 +385,9 @@ export class FacebookAdapter extends BotAdapter { // in case of Checkbox Plug-in sender.id is not present, instead we should look at optin.user_ref if (!message.sender && message.optin && message.optin.user_ref) { message.sender = { id: message.optin.user_ref }; + } else if (!message.sender){ + // Ignore message in case where message sender does not exist. FB Workplace sends messages automatically in some cases and botkit cannot read them causing it to throw an error + return } const activity: Activity = { From ce45f47c1ef69c53444f21fa93ba67a298303e66 Mon Sep 17 00:00:00 2001 From: Marco Maldonado Date: Tue, 23 May 2023 14:52:01 -0700 Subject: [PATCH 2/4] updated name and version of npm package --- packages/botbuilder-adapter-facebook/package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/botbuilder-adapter-facebook/package.json b/packages/botbuilder-adapter-facebook/package.json index 57deb5a88..ae231b523 100644 --- a/packages/botbuilder-adapter-facebook/package.json +++ b/packages/botbuilder-adapter-facebook/package.json @@ -1,6 +1,6 @@ { - "name": "botbuilder-adapter-facebook", - "version": "1.0.12", + "name": "acn-botbuilder-adapter-facebook", + "version": "1.0.13", "description": "Connect Botkit or BotBuilder to Facebook Messenger", "main": "lib/index.js", "typings": "./lib/index.d.ts", From 93103c2e00c4f08a481b1e280a84e07ed8da5bd9 Mon Sep 17 00:00:00 2001 From: Marco Maldonado Date: Tue, 23 May 2023 14:52:56 -0700 Subject: [PATCH 3/4] updated package name --- packages/botbuilder-adapter-facebook/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/botbuilder-adapter-facebook/package.json b/packages/botbuilder-adapter-facebook/package.json index ae231b523..d6498f0ea 100644 --- a/packages/botbuilder-adapter-facebook/package.json +++ b/packages/botbuilder-adapter-facebook/package.json @@ -1,5 +1,5 @@ { - "name": "acn-botbuilder-adapter-facebook", + "name": "@marco.maldonado22/botbuilder-adapter-facebook", "version": "1.0.13", "description": "Connect Botkit or BotBuilder to Facebook Messenger", "main": "lib/index.js", From 5bafc84612263ccdceac1d116d53c952317c50e9 Mon Sep 17 00:00:00 2001 From: Marco Maldonado Date: Tue, 23 May 2023 15:58:53 -0700 Subject: [PATCH 4/4] update git url --- packages/botbuilder-adapter-facebook/package.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/botbuilder-adapter-facebook/package.json b/packages/botbuilder-adapter-facebook/package.json index d6498f0ea..ae7e7e5c0 100644 --- a/packages/botbuilder-adapter-facebook/package.json +++ b/packages/botbuilder-adapter-facebook/package.json @@ -26,13 +26,13 @@ "chatbots", "azure" ], - "homepage": "https://github.com/howdyai/botkit/blob/master/packages/botbuilder-adapter-facebook#readme", + "homepage": "https://github.com/marcopolo39/botkit/blob/master/packages/botbuilder-adapter-facebook#readme", "bugs": { - "url": "https://github.com/howdyai/botkit/issues" + "url": "https://github.com/marcopolo39/botkit/issues" }, "repository": { "type": "git", - "url": "https://github.com/howdyai/botkit.git" + "url": "https://github.com/marcopolo39/botkit.git" }, "dependencies": { "botbuilder": "^4.15.0",