Add config param noopCallbacks

Promotes noopCallbacks from a runtime CLI flag (--noop-callbacks) to a compile-time config param in ConverterParams. 

The param guard is at the top of each callback body, after C pointer dereference, so the compiler folds away the entire callback body in normal builds.

Callbacks are still registered and called by OTF2 — this isolates raw C-library read + dispatch overhead from Chapel processing overhead.
The write step is also skipped when noopCallbacks=true since there is no callgraph/metrics data to write.

Removes:
  --noop-callbacks CLI flag
  noopCallbacks field from ConverterConfig record and EvtCallbackArgs

[Reviewed by @brandon-neth]

Author: ShreyasKhandekar

apps/FastOTF2Converter/src/ConverterArgs.chpl

@@ -25,7 +25,6 @@ module ConverterArgs {
     var excludeHIP: bool;
     var timings: bool;
     var timingsCSV: string;
-    var noopCallbacks: bool;
   }
 
   // -------------------------------------------------------------------------
@@ -111,14 +110,6 @@ module ConverterArgs {
       help="Output directory for CSV timing files (writes run_<ts>.csv, tasks_<ts>.csv, phases_<ts>.csv)"
     );
 
-    var noopCallbacksArg = parser.addFlag(
-      name="noopCallbacks",
-      opts=["--noop-callbacks"],
-      defaultValue=false,
-      numArgs=0,
-      help="Disable all callback work to measure pure OTF2 read baseline"
-    );
-
     var logArg = parser.addOption(
       name="log",
       defaultValue="INFO",
@@ -137,7 +128,6 @@ module ConverterArgs {
     conf.excludeHIP = excludeHIPArg.valueAsBool();
     conf.timings = timingsArg.valueAsBool();
     conf.timingsCSV = timingsCSVArg.value();
-    conf.noopCallbacks = noopCallbacksArg.valueAsBool();
 
     try {
       log = logArg.value(): LogLevel;
@@ -200,8 +190,7 @@ module ConverterArgs {
       processesToTrack=processesToTrack,
       metricsToTrack=metricsToTrack,
       excludeMPI=conf.excludeMPI,
-      excludeHIP=conf.excludeHIP,
-      noopCallbacks=conf.noopCallbacks
+      excludeHIP=conf.excludeHIP
     );
   }
 }

apps/FastOTF2Converter/src/ConverterCommon.chpl

@@ -129,7 +129,6 @@ module ConverterCommon {
     const metricsToTrack: domain(string);
     const excludeMPI: bool = false;
     const excludeHIP: bool = false;
-    const noopCallbacks: bool = false;
   }
 
   record EvtCallbackContext {

apps/FastOTF2Converter/src/ConverterEvtReaders.chpl

@@ -8,6 +8,7 @@
 module ConverterEvtReaders {
   use FastOTF2;
   use ConverterCommon;
+  use ConverterParams;
   use Time;
   use CallGraphModule;
   use List;
@@ -119,8 +120,8 @@ module ConverterEvtReaders {
                       region: OTF2_RegionRef): OTF2_CallbackCode {
     var ctxPtr = userData: c_ptr(EvtCallbackContext);
     if ctxPtr == nil then return OTF2_CALLBACK_ERROR;
+    if noopCallbacks then return OTF2_CALLBACK_SUCCESS;
     ref ctx = ctxPtr.deref();
-    if ctx.evtArgs.noopCallbacks then return OTF2_CALLBACK_SUCCESS;
     var cbSw: stopwatch; cbSw.start();
     ref defCtx = ctx.defContext;
 
@@ -152,8 +153,8 @@ module ConverterEvtReaders {
                       region: OTF2_RegionRef): OTF2_CallbackCode {
     var ctxPtr = userData: c_ptr(EvtCallbackContext);
     if ctxPtr == nil then return OTF2_CALLBACK_ERROR;
+    if noopCallbacks then return OTF2_CALLBACK_SUCCESS;
     ref ctx = ctxPtr.deref();
-    if ctx.evtArgs.noopCallbacks then return OTF2_CALLBACK_SUCCESS;
     var cbSw: stopwatch; cbSw.start();
     ref defCtx = ctx.defContext;
 
@@ -188,8 +189,8 @@ module ConverterEvtReaders {
                        metricValues: c_ptrConst(OTF2_MetricValue)): OTF2_CallbackCode {
     var ctxPtr = userData: c_ptr(EvtCallbackContext);
     if ctxPtr == nil then return OTF2_CALLBACK_ERROR;
+    if noopCallbacks then return OTF2_CALLBACK_SUCCESS;
     ref ctx = ctxPtr.deref();
-    if ctx.evtArgs.noopCallbacks then return OTF2_CALLBACK_SUCCESS;
     var cbSw: stopwatch; cbSw.start();
     ref defCtx = ctx.defContext;
     const (locName, locGroup, _) = getLocationAndRegionInfo(defCtx, location, 0);

apps/FastOTF2Converter/src/ConverterParams.chpl

@@ -0,0 +1,14 @@
+// Copyright Hewlett Packard Enterprise Development LP.
+//
+// Compile-time configuration knobs for the converter.
+// All config params live here so they have a single source of truth.
+// Any module that needs a param adds: use ConverterParams;
+
+module ConverterParams {
+
+  // When true, event callback bodies are no-ops (return SUCCESS immediately).
+  // Callbacks are still registered and called by OTF2 — this measures raw
+  // C-library read + dispatch overhead without any Chapel processing.
+  config param noopCallbacks: bool = false;
+
+}

apps/FastOTF2Converter/src/FastOTF2Converter.chpl

@@ -2,6 +2,7 @@
 
 module FastOTF2Converter {
   use ConverterArgs;
+  use ConverterParams;
   use Strategy_Serial;
   use Strategy_LocBlock;
   use Strategy_LocGroupBlock;
@@ -23,6 +24,8 @@ module FastOTF2Converter {
   proc main(args: [] string) throws {
     const conf = parseConverterArgs(args);
     validatePaths(conf);
+    if noopCallbacks then
+      logWarn("Compiled with noopCallbacks=true — event callbacks are no-ops");
 
     // Capture baseline RSS per locale (before work)
     var baselineKiB: [0..#numLocales] int;

apps/FastOTF2Converter/src/Strategy_LocBlock.chpl

@@ -9,6 +9,7 @@
 module Strategy_LocBlock {
   use ConverterArgs;
   use ConverterCommon;
+  use ConverterParams;
   use ConverterDefReaders;
   use ConverterEvtReaders;
   use ConverterWriters;
@@ -86,10 +87,10 @@ module Strategy_LocBlock {
     logInfo("Trace loaded in ", global_sw.elapsed(), " seconds");
     logInfo("Writing ", conf.outputFormat: string, " files to directory: ", conf.outputDir);
 
-    const writeResult = if !conf.noopCallbacks
+    const writeResult = if !noopCallbacks
       then writeOutputForContext(mergedCtx, conf.outputFormat, conf.outputDir)
       else new WriteResult();
-    if !conf.noopCallbacks then
+    if !noopCallbacks then
       logInfo("Finished writing to ", conf.outputDir, " in ", writeResult.writeTime, " seconds");
     logInfo("Finished converting trace in ", global_sw.elapsed(), " seconds");
 

apps/FastOTF2Converter/src/Strategy_LocGroupBlock.chpl

@@ -9,6 +9,7 @@
 module Strategy_LocGroupBlock {
   use ConverterArgs;
   use ConverterCommon;
+  use ConverterParams;
   use ConverterDefReaders;
   use ConverterEvtReaders;
   use ConverterGroupMap;
@@ -90,7 +91,7 @@ module Strategy_LocGroupBlock {
       totalEventsRead += readResult.eventsRead;
 
       // Write immediately — each reader owns complete groups
-      const writeResult = if !conf.noopCallbacks
+      const writeResult = if !noopCallbacks
         then writeOutputForContext(evtContexts[i], conf.outputFormat, conf.outputDir)
         else new WriteResult();
 

apps/FastOTF2Converter/src/Strategy_LocGroupDistBlock.chpl

@@ -9,6 +9,7 @@
 module Strategy_LocGroupDistBlock {
   use ConverterArgs;
   use ConverterCommon;
+  use ConverterParams;
   use ConverterDefReaders;
   use ConverterEvtReaders;
   use ConverterGroupMap;
@@ -108,7 +109,7 @@ module Strategy_LocGroupDistBlock {
                               else 0.0, "%");
 
           // Write immediately — each reader owns complete groups
-          const writeResult = if !conf.noopCallbacks
+          const writeResult = if !noopCallbacks
             then writeOutputForContext(evtContexts[i], conf.outputFormat, conf.outputDir)
             else new WriteResult();
 

apps/FastOTF2Converter/src/Strategy_Serial.chpl

@@ -9,6 +9,7 @@
 module Strategy_Serial {
   use ConverterArgs;
   use ConverterCommon;
+  use ConverterParams;
   use ConverterDefReaders;
   use ConverterEvtReaders;
   use ConverterWriters;
@@ -39,10 +40,10 @@ module Strategy_Serial {
 
     logDebug("Total events read: ", totalEventsRead);
     logInfo("Writing ", conf.outputFormat: string, " files to directory: ", conf.outputDir);
-    const writeResult = if !conf.noopCallbacks
+    const writeResult = if !noopCallbacks
       then writeOutputForContext(evtCtx, conf.outputFormat, conf.outputDir)
       else new WriteResult();
-    if !conf.noopCallbacks then
+    if !noopCallbacks then
       logInfo("Finished writing to ", conf.outputDir, " in ", sw.elapsed(), " seconds");
     const taskTotalTime = taskSw.elapsed();
     const evtReadWriteTime = sw.elapsed();